Skip to content

🌱 Fix optional e2e tests #2493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🌱 Fix optional e2e tests #2493

wants to merge 1 commit into from

Conversation

lentzi90
Copy link
Member

@lentzi90 lentzi90 commented May 28, 2025 •
edited
Loading

What this PR does / why we need it:

This is

  • fixing the configmap for ironic 29.0
  • fixing e2e config for upgrade tests
  • installing some packages that are needed to run the tests in jenkins
    (pre-installed in github runners)
  • removing the inspector port from the list of exposed ports in kind
    since it is no longer needed.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2484

@metal3-io-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@metal3-io-bot metal3-io-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 28, 2025
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 28, 2025
@lentzi90
Copy link
Member Author

/test ?

@metal3-io-bot
Copy link
Contributor

@lentzi90: The following commands are available to trigger required jobs:

/test generate

/test gomod

/test manifestlint

/test markdownlint

/test shellcheck

/test test

The following commands are available to trigger optional jobs:

/test metal3-bmo-e2e-test-optional-pull

/test metal3-centos-e2e-basic-test-main

/test metal3-centos-e2e-feature-test-main-features

/test metal3-centos-e2e-feature-test-main-pivoting

/test metal3-centos-e2e-feature-test-main-remediation

/test metal3-centos-e2e-integration-test-main

/test metal3-dev-env-integration-test-centos-main

/test metal3-dev-env-integration-test-ubuntu-main

/test metal3-e2e-1-32-1-33-upgrade-test-main

/test metal3-e2e-clusterctl-upgrade-test-main

/test metal3-ubuntu-e2e-basic-test-main

/test metal3-ubuntu-e2e-feature-test-main-features

/test metal3-ubuntu-e2e-feature-test-main-pivoting

/test metal3-ubuntu-e2e-feature-test-main-remediation

/test metal3-ubuntu-e2e-integration-test-main

Use /test all to run the following jobs that were automatically triggered:

generate

gomod

manifestlint

shellcheck

test

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lentzi90
Copy link
Member Author

/test metal3-bmo-e2e-test-optional-pull

@metal3-io-bot metal3-io-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 28, 2025
@lentzi90
Copy link
Member Author

/test metal3-bmo-e2e-test-optional-pull

@lentzi90 lentzi90 force-pushed the lentzi90/e2e-optional branch from cb032db to f2d58bc Compare May 30, 2025 06:08
@lentzi90
Copy link
Member Author

/test metal3-bmo-e2e-test-optional-pull

@lentzi90 lentzi90 force-pushed the lentzi90/e2e-optional branch from f2d58bc to 88fba69 Compare May 30, 2025 06:14
@lentzi90
Copy link
Member Author

/test metal3-bmo-e2e-test-optional-pull

@lentzi90 lentzi90 force-pushed the lentzi90/e2e-optional branch from 88fba69 to 8e5a65f Compare May 30, 2025 07:10
@lentzi90
Copy link
Member Author

/test metal3-bmo-e2e-test-optional-pull

@metal3-io-bot metal3-io-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 30, 2025
@lentzi90
E2E: Fix e2e optional tests
ede1e3d 
This is
- fixing the configmap for ironic 29.0
- fixing e2e config for upgrade tests
- installing some packages that are needed to run the tests in jenkins
  (pre-installed in github runners)
- removing the inspector port from the list of exposed ports in kind
  since it is no longer needed.

Signed-off-by: Lennart Jern <[email protected]>
@lentzi90 lentzi90 force-pushed the lentzi90/e2e-optional branch from 8e5a65f to ede1e3d Compare May 30, 2025 08:39
@lentzi90
Copy link
Member Author

/test metal3-bmo-e2e-test-optional-pull

@lentzi90 lentzi90 marked this pull request as ready for review May 30, 2025 10:03
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 30, 2025
@lentzi90 lentzi90 changed the title 🌱 Fix optional e2e tests on PRs 🌱 Fix optional e2e tests May 30, 2025
@lentzi90 lentzi90 mentioned this pull request May 30, 2025
Open
@dtantsur
Copy link
Member

/approve

Rozzii
Rozzii reviewed May 30, 2025
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur, Rozzii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rozzii Rozzii Rozzii left review comments

@kashifest kashifest Awaiting requested review from kashifest

@peppi-lotta peppi-lotta Awaiting requested review from peppi-lotta

@dtantsur dtantsur Awaiting requested review from dtantsur

@iurygregory iurygregory Awaiting requested review from iurygregory

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BMO optional pull is broken
4 participants
@lentzi90 @metal3-io-bot @dtantsur @Rozzii