-
Notifications
You must be signed in to change notification settings - Fork 48
Enable to configure Exception Behavior #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This is due to the default Adapter.OnTurnError handling. Most will supply their own handler since they want friendlier messages. Also some will opt to handoff to a live agent. We could stand to make this more apparent. |
yes, and the ask here is to configure OnTurnError to only include the stack trace when InDevelopment. |
for the moment this code has been updated to only emit stack traces when deployed in debug mode. |
I would add to this... It is common for Cx to supply a different OnTurnError to handler for these exceptions. Display a friendlier message, hand-off to a live agent, etc... Future work should include an easier way to do this since it still requires a CloudAdapter subclass. Though... if |
By default we are sending the exception details, including the StackTrace, to the channel.
This is not recommended [1] and should be disabled by default, with an opt-in option for development, in the same way that WebAPI projects allow to use
app.UseDeveloperExceptionPage();
[1] https://cwe.mitre.org/data/definitions/209.html
The text was updated successfully, but these errors were encountered: