Native Sierra-tabs are not working in macOS 10.12.x #76537

dalisoft · 2019-07-03T19:24:16Z

VSCode Version: V1.36.0 (1.36.0) and higher
OS Version: macOS 10.12(.0-6)

Steps to Reproduce:

Download latest release
Try to use Sierra tab feature

Note: Insiders build already does not work on Sierra
Note 2: This feature works only for High Sierra and Mojave
Note 3: Can this feature be added to without OS specific? i.e. for Windows users and/or for El Capitan users?
Note 4: Upgrading to Mojave isn't solution as Mojave not available to all users

Does this issue occur when all extensions are disabled?: Yes

bpasero · 2019-07-04T05:51:00Z

@dalisoft are you saying that in VSCode 1.35 you could use native tabs on macOS Sierra (10.12.x) and now you need at least High Sierra (10.13.x) to use them?

dalisoft · 2019-07-04T05:59:35Z

@bpasero Only v1.35 worked for me (Sierra tab feature), before and last release works only in v10.13+ (old releases worked only 10.13+, i did not test latest release on 10.13+)

bpasero · 2019-07-04T06:07:42Z

@dalisoft that is weird, are you saying v1.34 also did NOT support native tabs on macOS Sierra 10.12.x?

We did an Electron update for 1.36, but I would be surprised if there is something that changed between 1.34 and 1.35 that could cause this.

dalisoft · 2019-07-04T06:14:19Z

Yes, v1.34 also did not worked. Insiders build also does not support native tabs, even it has fullscreen black space bug

bpasero · 2019-07-04T06:48:18Z

@dalisoft how exactly do you see that it is not working, does it partially work or not at all. Can you share your settings file?

dalisoft · 2019-07-04T06:59:22Z

It's not works at all

{
  "breadcrumbs.enabled": false,
  "extensions.autoUpdate": true,
  "telemetry.enableCrashReporter": false,
  "telemetry.enableTelemetry": false,
  "workbench.iconTheme": "material-icon-theme",
  "workbench.editor.highlightModifiedTabs": true,
  "workbench.editor.enablePreviewFromQuickOpen": false,
  "workbench.editor.enablePreview": false,
  "workbench.settings.enableNaturalLanguageSearch": false,
  "editor.wordWrap": "bounded",
  "editor.scrollBeyondLastLine": false,
  "editor.scrollBeyondLastColumn": 0,
  "editor.renderWhitespace": "all",
  "editor.cursorBlinking": "solid",
  "editor.cursorSmoothCaretAnimation": false,
  "editor.formatOnSave": true,
  "editor.formatOnPaste": false,
  "editor.formatOnType": false,
  "editor.minimap.enabled": false,
  "editor.minimap.renderCharacters": false,
  "editor.minimap.maxColumn": 200,
  "editor.minimap.showSlider": "always",
  "editor.defaultFormatter": "esbenp.prettier-vscode",
  "editor.fontFamily": "Monaco, Menlo, Consolas, 'Courier New', monospace",
  "editor.fontSize": 12,
  "editor.smoothScrolling": true,
  "editor.suggestSelection": "first",
  "editor.fontWeight": "100",
  "diffEditor.ignoreTrimWhitespace": false,
  "window.zoomLevel": 0,
  "window.title": "${dirty} ${activeEditorMedium}${separator}${rootName}",
  "window.nativeFullScreen": false,
  "window.nativeTabs": true,
  "javascript.validate.enable": false,
  "javascript.format.enable": false,
  "javascript.implicitProjectConfig.experimentalDecorators": true,
  "javascript.updateImportsOnFileMove.enabled": "always",
  "javascript.implicitProjectConfig.checkJs": true,
  "javascript.format.insertSpaceAfterSemicolonInForStatements": false,
  "javascript.suggest.autoImports": false,
  "typescript.validate.enable": false,
  "typescript.format.enable": false,
  "typescript.implementationsCodeLens.enabled": true,
  "typescript.referencesCodeLens.enabled": true,
  "typescript.updateImportsOnFileMove.enabled": "always",
  "css.validate": false,
  "less.validate": false,
  "scss.validate": false,
  "explorer.confirmDelete": false,
  "explorer.confirmDragAndDrop": false,
  "explorer.openEditors.visible": 0,
  "files.watcherExclude": {
    "**/.git/objects/**": true,
    "**/.git/subtree-cache/**": true,
    "**/node_modules/**": true,
    "**/dist/**": true,
    "**/build/**": true,
    "**/.cache/**": true,
    "**/.webpack/**": true
  },
  "files.autoSave": "onWindowChange",
  "files.trimTrailingWhitespace": true,
  "files.insertFinalNewline": true,
  "files.associations": {
    "*.js": "javascriptreact",
    "*.ts": "typescriptreact",
    "*.css": "postcss"
  },
  "eslint.autoFixOnSave": true,
  "eslint.runtime": "/usr/local/bin/node",
  "eslint.validate": [
    {
      "language": "vue",
      "autoFix": true
    },
    {
      "language": "javascript",
      "autoFix": true
    },
    {
      "language": "javascriptreact",
      "autoFix": true
    }
  ],
  "prettier.stylelintIntegration": true,
  "prettier.printWidth": 80,
  "prettier.jsxBracketSameLine": true,
  "prettier.arrowParens": "avoid",
  "prettier.eslintIntegration": true,
  "prettier.tslintIntegration": true,
  "prettier.requireConfig": false,
  "stylelint.enable": true,
  "emmet.includeLanguages": {
    "postcss": "css",
    "javascript": "javascriptreact"
  },
  "emmet.syntaxProfiles": {
    "postcss": "css"
  },
  "postcssSorting.config": {
    "order": [
      "custom-properties",
      "dollar-variables",
      "declarations",
      "at-rules",
      "rules"
    ],
    "properties-order": [
      "display",
      "position",
      "top",
      "right",
      "bottom",
      "left"
    ]
  },
  "sync.gist": "GIST_ID",
  "sync.autoUpload": false,
  "sync.autoDownload": false,
  "git.autofetch": true,
  "git.enableSmartCommit": true,
  "vsintellicode.modify.editor.suggestSelection": "automaticallyOverrodeDefaultValue",
  "terminal.explorerKind": "external",
  "terminal.integrated.shell.windows": "C:\\WINDOWS\\System32\\wsl.exe",
  // "terminal.integrated.shellArgs.windows": ["~"],
  "search.exclude": {
    "**/.cache": true,
    "**/.out": true,
    "**/build": true,
    "**/dist": true
  },
  "markdown.preview.fontFamily": "-apple-syLight BlinkMacSystemFont, 'Segoe WPC', 'Segoe UI', 'Ubuntu', 'Droid Sans', sans-serif",
  "workbench.editor.closeOnFileDelete": true,
  "workbench.colorTheme": "Oceanic Plus",
  "typescript.experimental.useSeparateSyntaxServer": true,
  "update.mode": "none",
  "update.enableWindowsBackgroundUpdates": false,
  "workbench.statusBar.feedback.visible": false
}

bpasero · 2019-07-04T07:12:30Z

@dalisoft ok I am sorry to hear that but I cannot tell why it fails for you :-(

dalisoft · 2019-07-04T07:19:55Z

Thanks. Lets wait for fix

Platzii · 2019-07-04T20:17:56Z

Having the same issue.
Running macOS Sierra (1.12.x), before VSCode 1.36.0 native window tabbing worked after update they did not anymore.

bpasero · 2019-07-10T07:57:07Z

Given the comment in #77047 I think this is another Electron 4 related regression.

//cc @deepak1556

bpasero · 2019-07-10T07:57:37Z

We are building exploration builds that use a much newer version of our UI framework (Electron version 6.0.x). I wonder if this issue reproduces with one of these builds, could you try? Download:

macOS: Download
Linux (DEB): Download
Linux (RPM): Download
Windows: Download

igrek8 · 2019-07-10T08:00:19Z

@bpasero, I have just tested macOS code-exploration. The issue is still present.

Again, I enabled window: Native Tabs, because code-exploration had a zero config

Version: 1.37.0-exploration
Commit: 54c6f2047b7e26f9dd6f991d9831ead1f06964b2
Date: 2019-07-09T10:05:44.909Z
Electron: 6.0.0-beta.12
Chrome: 76.0.3809.54
Node.js: 12.0.0
V8: 7.6.303.18-electron.0
OS: Darwin x64 16.7.0

Platzii · 2019-07-10T13:52:02Z

@bpasero, I can confirm the issue still persists with the exploration build

By the way:
In order to reproduce, you must set "Prefer tabs when opening documents" to "Always" in System Preferences > Dock

igrek8 · 2019-08-09T06:55:24Z

Good day everyone,

The issue has not been resolved yet. Unfortunately, it forces me to downgrade to v1.35 every time it automatically updates to v1.36 or v1.37.

None of the suggested solutions work. I tried to install the nightly build, etc.

Is there an investigation or any update?

dalisoft · 2019-08-09T07:24:15Z

@crabicode Hi!

You can disable auto-update from Settings.
I updated to Mojave (latest update) and performance was improved, these bugs are fixed and memory usage was reduced to 1.5 times which is huge as i'm using old macBook with 8Gb memory

igrek8 · 2019-08-09T12:17:47Z

@dalisoft,

I was reluctant to upgrade to Mojave because vscode could not open projects in the same window. Could you confirm vscode opens projects in native tabs in Mojave?

Thank you very much!

dalisoft · 2019-08-09T14:30:24Z

Yes, Sierra native-tab feature works as well as

Performance was improved
Reduced CPU usage
Reduced Memory usage

Sorry, things are improved in Code (VSCode), not related to Mojave, but in Mojave black space is missing and native-tab feature working

I glad i updated. I recommend you upgrade to only latest upgrade due of security and stability.

bpasero · 2019-10-15T14:39:01Z

I will reopen this as I think we should still report this to Electron.

Is anyone here in the issue willing to distill a reproducible case against Electron so that we can report this?

vscodebot · 2019-10-22T14:50:20Z

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

bpasero · 2019-10-22T15:21:19Z

Anyone?

dalisoft · 2019-10-22T15:29:18Z

I don’t have macOS Sierra currently, issue already fixed?

bpasero · 2019-10-22T15:38:55Z

I think there are still people that complain that native tabs are not working with macOS 10.12. Waiting for someone with 10.12 to respond, then we can see to reproduce with a simple Electron app.

dalisoft · 2019-10-22T15:43:04Z

I try install Sierra and test in weekend

bpasero · 2019-10-22T15:54:00Z

Thanks!

It should be as easy as:

download Electron fiddle
pick Electron 6
in the browser window options add: tabbingIdentifier: "foo"
run it

dalisoft · 2019-10-23T07:30:25Z

@bpasero
I can confirm it is does not work

Electron 6.x latest

Electron 6.0.12

OS Info

bpasero · 2019-10-23T07:48:42Z

@dalisoft thanks a ton for doing this ❤️ . Now as a last step, can you distill this into an issue against Electron here and link the bug back here?

dalisoft · 2019-10-23T07:52:29Z

I try @bpasero, now or just later as also i should test which Electron works fine :)

dalisoft · 2019-10-23T12:12:10Z

@bpasero You can track bug at here in Electron repository

dalisoft · 2019-11-11T14:07:31Z

I found workaround by trying many ways to get it work in Sierra.

Required: System Preferences -> Dock -> Open document in tabs -> Only in full-screen mode.

Run VSCode
Maximize / make it Full-screen
Click Window -> New Tab in VSCode
Make revert window status to previous state (no full-screen)
Maximize again.
Enjoy working solution.

If you want open new tabs, try 3-5 steps again.

Note: If you forgot steps 4 and 5, you able to use native-tabs, but top tabs bar will be empty or hidden (i don't why)

This solution tested in v1.40 and v1.39.

Hope it helps you 😄

dalisoft · 2022-09-01T20:22:47Z

@bpasero As linked issues are closed, this can be closed too

vscodebot bot added the new release label Jul 3, 2019

dbaeumer assigned bpasero Jul 3, 2019

bpasero added the info-needed Issue requires more information from poster label Jul 4, 2019

bpasero changed the title ~~VSCode: Sierra-tab feature on macOS disappearing/not working with every new release~~ Native Sierra-tabs are not working in macOS 10.12.x Jul 4, 2019

bpasero added electron Issues and items related to Electron upstream Issue identified as 'upstream' component related (exists outside of VS Code) and removed info-needed Issue requires more information from poster labels Jul 4, 2019

bpasero added the macos Issues with VS Code on MAC/OS X label Jul 4, 2019

vscodebot bot removed the new release label Jul 8, 2019

bpasero mentioned this issue Jul 10, 2019

Window: Native Tabs does not open new windows as tabs in MacOS Sierra #77047

Closed

bpasero added the electron-4.0.x-update label Jul 10, 2019

bpasero assigned deepak1556 Jul 10, 2019

rcarmo mentioned this issue Aug 27, 2019

Accessibility: macOS Native tabs #79920

Closed

bpasero closed this as completed Oct 9, 2019

bpasero mentioned this issue Oct 10, 2019

open a new tab will create black fullscreen on fullscreen mode #82216

Closed

bpasero reopened this Oct 15, 2019

bpasero added the info-needed Issue requires more information from poster label Oct 15, 2019

bpasero mentioned this issue Oct 15, 2019

Exception for using electron API for OS events. #82588

Closed

vscodebot bot closed this as completed Oct 22, 2019

bpasero reopened this Oct 22, 2019

bpasero removed the info-needed Issue requires more information from poster label Oct 22, 2019

dalisoft mentioned this issue Oct 23, 2019

macOS Sierra - Native tabs does not work electron/electron#20703

Closed

3 tasks

bpasero added the upstream-issue-linked This is an upstream issue that has been reported upstream label Oct 23, 2019

bpasero removed their assignment Dec 5, 2019

dalisoft mentioned this issue Sep 14, 2021

macOS Native Tabs and Full Screen was broken #133080

Closed

deepak1556 removed the electron-4-update label Feb 18, 2022

dalisoft mentioned this issue Apr 17, 2022

VSCode crashed while trying to restore full-screen #147606

Closed

dalisoft closed this as completed Sep 1, 2022

dalisoft mentioned this issue Oct 6, 2022

macOS Native Tabs creation crash #162877

Closed

github-actions bot locked and limited conversation to collaborators Oct 18, 2022

Native Sierra-tabs are not working in macOS 10.12.x #76537

Native Sierra-tabs are not working in macOS 10.12.x #76537

Comments

dalisoft commented Jul 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

bpasero commented Jul 4, 2019

Uh oh!

dalisoft commented Jul 4, 2019

Uh oh!

bpasero commented Jul 4, 2019

Uh oh!

dalisoft commented Jul 4, 2019

Uh oh!

bpasero commented Jul 4, 2019

Uh oh!

dalisoft commented Jul 4, 2019

Uh oh!

bpasero commented Jul 4, 2019

Uh oh!

dalisoft commented Jul 4, 2019

Uh oh!

Platzii commented Jul 4, 2019

Uh oh!

bpasero commented Jul 10, 2019

Uh oh!

bpasero commented Jul 10, 2019

Uh oh!

igrek8 commented Jul 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Platzii commented Jul 10, 2019

Uh oh!

igrek8 commented Aug 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dalisoft commented Aug 9, 2019

Uh oh!

igrek8 commented Aug 9, 2019

Uh oh!

dalisoft commented Aug 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bpasero commented Oct 15, 2019

Uh oh!

vscodebot bot commented Oct 22, 2019

Uh oh!

bpasero commented Oct 22, 2019

Uh oh!

dalisoft commented Oct 22, 2019

Uh oh!

bpasero commented Oct 22, 2019

Uh oh!

dalisoft commented Oct 22, 2019

Uh oh!

bpasero commented Oct 22, 2019

Uh oh!

dalisoft commented Oct 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Electron 6.x latest

Electron 6.0.12

OS Info

Uh oh!

bpasero commented Oct 23, 2019

Uh oh!

dalisoft commented Oct 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dalisoft commented Oct 23, 2019

Uh oh!

dalisoft commented Nov 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dalisoft commented Sep 1, 2022

Uh oh!

dalisoft commented Jul 3, 2019 •

edited

Loading

igrek8 commented Jul 10, 2019 •

edited

Loading

igrek8 commented Aug 9, 2019 •

edited

Loading

dalisoft commented Aug 9, 2019 •

edited

Loading

dalisoft commented Oct 23, 2019 •

edited

Loading

dalisoft commented Oct 23, 2019 •

edited

Loading

dalisoft commented Nov 11, 2019 •

edited

Loading