Resize reset terminal?

[georges]

First, thanks for the fantastic project. I foolishly started to write code to render a terminal for a new iOS project and quickly realized how much goes into it!

One issue I've encountered is that when the keyboard visibility change or the view gets rotated, the TerminalView is getting a resize to new cols/rows. So far so good. Unfortunately the content of the Terminal gets wiped as well. Upon looking at the code I see that:

SwiftTerm/Sources/SwiftTerm/Apple/AppleTerminalView.swift

Lines 1120 to 1125 in c5f1d05

	public func resize (cols: Int, rows: Int)
	{
	terminal.resize (cols: cols, rows: rows)
	sizeChanged (source: terminal)
	terminal.resetToInitialState()
	}

Invokes the terminal.resetToInitialState() which as far as I can tell is causing the Terminal to re-initialize and clear the buffer.

I feel like I'm missing something fundamental as this seems like quite an undesirable behavior.

What am I missing?

[migueldeicaza]

This might be a remnant of the original pre-reflow code, and it might be possible to remove, because terminal.resize() now handles the reflow.

It might be desirable to replace with the soft reset, instead of that one.

[georges]

#367