Skip to content

Textarea TV loses Auto Grow and Resizable settings on reload #16746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
eremozin opened this issue May 16, 2025 · 3 comments · May be fixed by #16747
Open

Textarea TV loses Auto Grow and Resizable settings on reload #16746

eremozin opened this issue May 16, 2025 · 3 comments · May be fixed by #16747
Labels
bug The issue in the code or project, which should be addressed.

Comments

@eremozin
Copy link

Bug Report

Summary

The Textarea TV with Auto Grow and Resizable enabled resets these settings when the TV is reloaded or reopened.

Steps to Reproduce

  1. Create a Template Variable (TV) with the input type set to Textarea.
  2. Disable Auto Grow and Resizable options.
  3. Save and reload or reopen the TV.

Environment

MODX version: 3.1.2-pl
@eremozin eremozin added the bug The issue in the code or project, which should be addressed. label May 16, 2025
@halftrainedharry
Copy link
Contributor

The problem seems to be the function paramValueIsTrue() that was added with #16553 (in MODX 3.1.0):

revolution/core/src/Revolution/modX.php

Lines 402 to 416 in ba4e3d4

* Evaluate boolean-like parameter value and return it as an actual boolean or as a string; a string may be
* needed/preferred when building code blocks (e.g., javascript) via php strings (nowdoc/heredoc ones in particular).
*
* @param array $params An associative or numeric-indexed array of parameters
* @param string|int $key The array key to evaluate
* @param bool $returnBoolAsString Whether to return the string representation ('true' or 'false') of the boolean value
* @return string|bool
*/
public function paramValueIsTrue(array $params, $key, bool $returnBoolAsString = false)
{
if (isset($params[$key]) && in_array($params[$key], ['true', true, '1', 1])) {
return $returnBoolAsString ? 'true' : true ;
}
return $returnBoolAsString ? 'false' : false ;
}

Because in_array('false',[true]); seems to return true in PHP, the function returns true when the value is the string 'false'.

@halftrainedharry
Copy link
Contributor

The solution is probably to use the third parameter ($strict) of the in_array function and to change the line

revolution/core/src/Revolution/modX.php

Line 412 in ba4e3d4

if (isset($params[$key]) && in_array($params[$key], ['true', true, '1', 1])) {

to this instead:

if (isset($params[$key]) && in_array($params[$key], ['true', true, '1', 1], true)) {

@smg6511 smg6511 linked a pull request May 22, 2025 that will close this issue
Open
@smg6511
Copy link
Collaborator

smg6511 commented May 22, 2025

@halftrainedharry - Yup, thanks for taking a look. I put up a PR to fix it. It is indeed resolved by specifying strict checking. The mystery is, why didn't the problem show up when I added those options a while back? Who knows ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug The issue in the code or project, which should be addressed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FIx Textarea TV Input Options smg6511/revolution
3 participants
@smg6511 @eremozin @halftrainedharry