Skip to content

[bug] moon run --quiet overrides --summary #1931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chadrik opened this issue Apr 23, 2025 · 2 comments
Open

[bug] moon run --quiet overrides --summary #1931

chadrik opened this issue Apr 23, 2025 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@chadrik
Copy link
Contributor

chadrik commented Apr 23, 2025

Describe the bug

(this is somewhere between a bug and a feature request)

If I explicitly provide the --summary flag, the summary should be printed even if I also pass --quiet. The purpose of quiet is to "hide all non-important terminal output", which essentially means the ▪▪▪▪ core:mypy (e48410e3) style progress reports. I would like to remove those and also have a summary.

Expected behavior

If I run moon run --quiet --summary I expect the ▪▪▪▪ lines to be removed, but the summary to be printed.

Additional context

With the last 3 issues that I've submitted I'm working towards creating what I consider the ideal level of verbosity for moon run.

This translates to:

And finally, all of this gets tied together with the ability to configure these as the default without needing to provide these three options to moon run each time: #1929

One thing to consider is that perhaps what would be best is finer grained control over each type of logged output. As far as I can tell there are 5 categories of output:

type control
progress reports suppressed with --quiet
task outputs (stdout / stderr) only configurable at the task level, via options.outputStyle
review enabled with --summary. suppressed with --quiet
summary enabled with --summary. suppressed with --quiet
stats suppressed with --quiet

As you can see there are many combinations which are simply not configurable by any means with the current controls.

@chadrik chadrik added the bug Something isn't working label Apr 23, 2025
@chadrik
Copy link
Contributor Author

chadrik commented Apr 23, 2025

As another example of why output configurability is useful is that I could see that enabling only the review and summary outputs (and disabling all others, including task output) would be an ideal output level for certain contexts, like running pre-commit hooks.

@milesj
Copy link
Collaborator

milesj commented Apr 28, 2025

--quiet definitely needs work. It was added to deal with --json and other outputs, but it's not working 100% as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants