Skip to content

[feature] Extend webhook functionalities #1961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
harlequin opened this issue May 9, 2025 · 1 comment
Open

[feature] Extend webhook functionalities #1961

harlequin opened this issue May 9, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@harlequin
Copy link
Contributor

harlequin commented May 9, 2025

A great feature would be if the notification webhook will have 2 additional improvements:

  1. Define that the webhook has to be acknowledged via 2xx return code

    Implementation would be as a configure option notifier.acknowledge with true or false inside the workspace.yml if webhooks are a fire and forget or wait for 2xx response.

  2. Define global Trace ID via Environment variable.

    Currently it is implemented that every pipeline run will calculates it's own UUID for every pipeline run.
    In the scenario that we are splitting the jobs across different machines, moon ci --jobs --jobsTotal, it would be great that the user can calculate it's own "CI ID" before executing the moon commands.

    With this the data can be analysed across machines.

@milesj: If you are agreeing that this is feature makes sense, I can provide the merge request.

@harlequin harlequin added the enhancement New feature or request label May 9, 2025
@milesj
Copy link
Collaborator

milesj commented May 9, 2025

@harlequin Yeah this sounds fine. Feel free to submit a PR for the develop-1.36 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants