You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It seems that moon is not detecting configuration changes when modifying a file that is imported from elsewhere in PKL.
Steps to reproduce
Create a PKL configuration file for any project, or for the workspace (project/moon.pkl or .moon/workspace.pkl).
Create an imported file called imported.pkl that contains some moon configuration options. And import it into your main configuration file (using either import, amends or extends in PKL).
Run anything that's contained in the config. Then add change to imported.yml.
Re-run the target, changes are not reflected and the old configuration is used.
When using --cache write or --cache off, it works. It also works when we modify the main moon.yml file. So apparently moon cache system only checks for changes on this file.
Maybe configuration files cache should be disabled when using PKL files ? Or maybe moon should somehow detect if other files are imported (that sounds more difficult).
Expected behavior
When modifying imported.pkl, moon should pick up the changes.
Environment
Linux 64 bits (Ubuntu)
I am using pkl in version 0.28.2
btw, I don't know if you remember me, we had a little chat on reddit last year. i also wrote a monorepo tool in Rust. I am currently trying moon and it's been great so far ! so cheers
The text was updated successfully, but these errors were encountered:
Nice report. This is definitely a lack of surface area on moon's part. I'm not sure how to solve this without actually reading and manually parsing these .pkl files somehow.
The problem is that the files are passed to the pkl binary and evaluated behind the scenes, outside the context of moon.
Describe the bug
It seems that
moon
is not detecting configuration changes when modifying a file that is imported from elsewhere in PKL.Steps to reproduce
Create a PKL configuration file for any project, or for the workspace (
project/moon.pkl
or.moon/workspace.pkl
).Create an imported file called
imported.pkl
that contains some moon configuration options. And import it into your main configuration file (using eitherimport
,amends
orextends
in PKL).Run anything that's contained in the config. Then add change to
imported.yml
.Re-run the target, changes are not reflected and the old configuration is used.
When using
--cache write
or--cache off
, it works. It also works when we modify the mainmoon.yml
file. So apparentlymoon
cache system only checks for changes on this file.Maybe configuration files cache should be disabled when using PKL files ? Or maybe
moon
should somehow detect if other files are imported (that sounds more difficult).Expected behavior
When modifying
imported.pkl
, moon should pick up the changes.Environment
Linux 64 bits (Ubuntu)
I am using
pkl
in version 0.28.2btw, I don't know if you remember me, we had a little chat on reddit last year. i also wrote a monorepo tool in Rust. I am currently trying
moon
and it's been great so far ! so cheersThe text was updated successfully, but these errors were encountered: