Skip to content

feat(editor): Add functionality to create folders #13473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 35 commits into from
Feb 28, 2025

Conversation

MiloradFilipovic
Copy link
Contributor

@MiloradFilipovic MiloradFilipovic commented Feb 24, 2025

Summary

image

Additional improvements:

  • Fixing breadcrumbs
    image
    image
  • Adding folder option to project split button
    image
  • Saving workflows i a folder
  • Adding folders store with folders cache

Related Linear tickets, Github issues, and Community forum posts

Closes ADO-3180
Closes ADO-3156

Testing

Test instance with working back-end (and bits of front-end for the next phase) is linked here.
I will be adding e2e tests for this as soon as needed parts of back-end are merged to master

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@MiloradFilipovic MiloradFilipovic self-assigned this Feb 24, 2025
@MiloradFilipovic MiloradFilipovic marked this pull request as draft February 24, 2025 13:57
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Feb 24, 2025
@MiloradFilipovic MiloradFilipovic force-pushed the ADO-3180-create-folders-functionality branch from 3d4212e to ce4fc00 Compare February 26, 2025 13:11
@MiloradFilipovic MiloradFilipovic force-pushed the ADO-3180-create-folders-functionality branch from 6a467eb to 5e5d0fe Compare February 26, 2025 14:21
@MiloradFilipovic MiloradFilipovic marked this pull request as ready for review February 27, 2025 10:10
@mutdmour
Copy link
Contributor

@MiloradFilipovic PR looks good. Thanks for addressing my PR feedback. Let me know when the build is green to approve.

Copy link

cypress bot commented Feb 28, 2025

n8n    Run #9572

Run Properties:  status check failed Failed #9572  •  git commit 2cb9d9e29f: 🌳 master 🖥️ browsers:node18.12.0-chrome107 🤖 PR User 🗃️ e2e/*
Project n8n
Branch Review master
Run status status check failed Failed #9572
Run duration 01m 04s
Commit git commit 2cb9d9e29f: 🌳 master 🖥️ browsers:node18.12.0-chrome107 🤖 PR User 🗃️ e2e/*
Committer Milorad FIlipović
View all properties for this run ↗︎

Test results
Tests that failed  Failures 2
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 59
Tests that passed  Passing 0
View all changes introduced in this branch ↗︎

Tests for review

Failed  5-ndv.cy.ts • 1 failed test

View Output Video

Test Artifacts
NDV > should show up when double clicked on a node and close when Back to canvas clicked Test Replay Screenshots Video
Failed  4-node-creator.cy.ts • 1 failed test

View Output Video

Test Artifacts
Node Creator > should open node creator on trigger tab if no trigger is on canvas Test Replay Screenshots Video
Failed  12-canvas.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  30-langchain.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  20-workflow-executions.cy.ts • 0 failed tests

View Output

Test Artifacts

The first 5 failed specs are shown, see all 63 specs in Cypress Cloud.

Copy link
Contributor

✅ All Cypress E2E specs passed

@MiloradFilipovic MiloradFilipovic merged commit 2cb9d9e into master Feb 28, 2025
38 checks passed
@MiloradFilipovic MiloradFilipovic deleted the ADO-3180-create-folders-functionality branch February 28, 2025 14:50
@github-actions github-actions bot mentioned this pull request Mar 3, 2025
@janober
Copy link
Member

janober commented Mar 3, 2025

Got released with [email protected]

@xhzkp
Copy link

xhzkp commented Mar 3, 2025

@janober @MiloradFilipovic
I did not find the folder creation function.

folder.mp4

@MiloradFilipovic
Copy link
Contributor Author

@janober @MiloradFilipovic I did not find the folder creation function.

folder.mp4

hey @xhzkp this is still work in progress but stay tuned, it should be coming your way as soon as we polish it

@joaoescribano
Copy link

Just to test, while it's not fully polished, just add N8N_FOLDERS_ENABLED=true to the env variables

MrJasperTan pushed a commit to MrJasperTan/n8n that referenced this pull request Mar 17, 2025
xbinaryx pushed a commit to xbinaryx/n8n that referenced this pull request Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants