-
Notifications
You must be signed in to change notification settings - Fork 28.4k
feat(editor): Add functionality to create folders #13473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(editor): Add functionality to create folders #13473
Conversation
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
3d4212e
to
ce4fc00
Compare
6a467eb
to
5e5d0fe
Compare
@MiloradFilipovic PR looks good. Thanks for addressing my PR feedback. Let me know when the build is green to approve. |
n8n
|
Project |
n8n
|
Branch Review |
master
|
Run status |
|
Run duration | 01m 04s |
Commit |
|
Committer | Milorad FIlipović |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
2
|
|
0
|
|
0
|
|
59
|
|
0
|
View all changes introduced in this branch ↗︎ |
Tests for review
5-ndv.cy.ts • 1 failed test
Test | Artifacts | |
---|---|---|
NDV > should show up when double clicked on a node and close when Back to canvas clicked |
Test Replay
Screenshots
Video
|
4-node-creator.cy.ts • 1 failed test
Test | Artifacts | |
---|---|---|
Node Creator > should open node creator on trigger tab if no trigger is on canvas |
Test Replay
Screenshots
Video
|
The first 5 failed specs are shown, see all 63 specs in Cypress Cloud.
✅ All Cypress E2E specs passed |
Got released with |
@janober @MiloradFilipovic folder.mp4 |
hey @xhzkp this is still work in progress but stay tuned, it should be coming your way as soon as we polish it |
Just to test, while it's not fully polished, just add |
Summary
Additional improvements:
Related Linear tickets, Github issues, and Community forum posts
Closes ADO-3180
Closes ADO-3156
Testing
Test instance with working back-end (and bits of front-end for the next phase) is linked here.
I will be adding e2e tests for this as soon as needed parts of back-end are merged to
master
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)