Skip to content

fix(editor): Close saving modal when workflow is new #14836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 29, 2025
Merged

fix(editor): Close saving modal when workflow is new #14836

merged 9 commits into from
Apr 29, 2025

Conversation

mutdmour
Copy link
Contributor

Summary

Close saving modal when workflow is new

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Apr 23, 2025
cubic-dev-ai[bot]
cubic-dev-ai bot reviewed Apr 23, 2025
View reviewed changes
Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mrge found 1 issue across 5 files. View it in mrge.io

@codecov Codecov
Copy link

codecov bot commented Apr 23, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.75000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...end/editor-ui/src/composables/useWorkflowSaving.ts 98.61% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@mutdmour mutdmour requested review from a team, alexgrozav and r00gm April 24, 2025 10:24
alexgrozav
alexgrozav previously approved these changes Apr 29, 2025
View reviewed changes
Copy link
Member

@alexgrozav alexgrozav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thanks for doing this. 🙌

@mutdmour mutdmour requested a review from alexgrozav April 29, 2025 10:46
@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@mutdmour mutdmour merged commit 48f0c91 into master Apr 29, 2025
36 checks passed
@mutdmour mutdmour deleted the ADO-3477 branch April 29, 2025 13:48
guillaumejacquart pushed a commit that referenced this pull request Apr 30, 2025
@mutdmour @guillaumejacquart
fix(editor): Close saving modal when workflow is new (#14836)
0366547
@github-actions github-actions bot mentioned this pull request May 5, 2025
Merged
@janober
Copy link
Member

janober commented May 5, 2025

Got released with [email protected]

ozcangungor pushed a commit to ozcangungor/n8n that referenced this pull request May 25, 2025
@mutdmour @ozcangungor
fix(editor): Close saving modal when workflow is new (n8n-io#14836)
e1faef6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

@alexgrozav alexgrozav alexgrozav approved these changes

@r00gm r00gm Awaiting requested review from r00gm

Assignees
No one assigned
Labels
n8n team Authored by the n8n team Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mutdmour @janober @alexgrozav