fix(editor): "Trigger node not found" error when chat message is entered #14954
Conversation
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
| watch( | ||
| () => allConnections.value, | ||
| () => { | ||
| if (canvasStore.isLoading) return; |
There was a problem hiding this comment.
This was the condition that caused the "Chat Trigger not found" error. The new implementation uses computed() in useChatTrigger to ensure latest workflow in the store is read when the value is referenced.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| const objectIterator = (input: any): any => { | ||
| if (seen.has(input)) { |
There was a problem hiding this comment.
Objects that are part of a circular reference are returned without converting nested Vue reactive objects to raw
| @@ -505,6 +505,13 @@ export function usePushConnection({ router }: { router: ReturnType<typeof useRou | |||
| } | |||
|
|
|||
| workflowsStore.executingNode.length = 0; | |||
|
|
|||
| if (receivedData.type === 'executionFinished') { | |||
There was a problem hiding this comment.
This condition should be expanded to also handle 'executionRecovered' type since both types execute the same code block afterwards and likely need the same cleanup
packages/frontend/editor-ui/src/components/CanvasChat/composables/useChatState.ts
Show resolved
Hide resolved
|
✅ All Cypress E2E specs passed |
|
Got released with |
Summary
This PR implements a fix of the bug described in the title, along with some stylistic tweaks and bugfixes to the new logs view.
To test locally, set environment variable
N8N_ENABLE_LOGS_VIEWtotruewhen starting the server.Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/SUG-41/bug-trigger-node-not-found-error-when-chat-message-is-entered
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)