fix(core): Add support for proxy using forward headers

[Phiph]

Summary

This pull request introduces support for proxies in the Push class by utilizing X-Forwarded headers to determine the expected origin, along with enhanced logging to debug origin-related issues.

Support for proxies:

• Added logic to prefer X-Forwarded-Host and X-Forwarded-Proto headers over the standard Host and Origin headers to compute the expectedOrigin. This ensures compatibility when the application is behind a proxy.

Enhanced logging:

• Introduced detailed debug logs to capture the values of Host, Origin, X-Forwarded-Host, X-Forwarded-Proto, and the computed expectedOrigin. This helps in identifying mismatches between the Origin header and the expectedOrigin.

Related Linear tickets, Github issues, and Community forum posts

fixes: #14619, #14653

Review / Merge checklist

• PR title and summary are descriptive. (conventions)
• Docs updated or follow-up ticket created.
• Tests included.
• PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

[CLAassistant]

All committers have signed the CLA.

[cubic-dev-ai]

mrge found 3 issues across 1 file. View them in mrge.io

[Joffcom]

Hey @Phiph,

Thanks for the PR, We have created "GHC-1804" as the internal reference to get this reviewed.

One of us will be in touch if there are any changes needed, in most cases this is normally within a couple of weeks but it depends on the current workload of the team.

[Phiph]

hey @despairblue thanks for adding the tests and cleaning up the implementation. :) I was going to look at the tests tomorrow! I appreciate it!

Is there anything you'd like me to do?

[despairblue]

hey @despairblue thanks for adding the tests and cleaning up the implementation. :) I was going to look at the tests tomorrow! I appreciate it!

Is there anything you'd like me to do?

No problem. Thanks for the initial work ❤️

[cubic-dev-ai]

cubic reviewed 2 files and found no issues. Review PR in cubic.dev.

[Cadiac]

Left some comments, but overall this looks like a good solution to solve the issue we have 👍

[Cadiac]

There's also Forwarded header with an optional host field that some people might use, but we can discuss adding support for that on another ticket too.

https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/Forwarded

[Cadiac]

🚀

[shortstacked]

/test-workflows

[janober]

Got released with [email protected]

[neylwalecki]

Tested with my setup on AWS + Ubuntu + Litespeed Web Server + CyperPanel, and unfortunately it doesn't fix the "lost connection/websocket" issue. It seems that the culprit is the Litespeed Web Server.