Skip to content

feat(editor): Rollout improved log view #15202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2025
Merged

feat(editor): Rollout improved log view #15202

merged 2 commits into from
May 8, 2025

Conversation

autologie
Copy link
Contributor

@autologie autologie commented May 8, 2025

Summary

This PR enables the improved log view by default and updates e2e tests to work with this configuration.

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels May 8, 2025
Copy link

codecov bot commented May 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link

cypress bot commented May 8, 2025

n8n    Run #10670

Run Properties:  status check failed Failed #10670  •  git commit 70b3bd7b40: 🌳 enable-log-view 🖥️ browsers:node18.12.0-chrome107 🤖 schedule 🗃️ e2e/*
Project n8n
Branch Review enable-log-view
Run status status check failed Failed #10670
Run duration 05m 59s
Commit git commit 70b3bd7b40: 🌳 enable-log-view 🖥️ browsers:node18.12.0-chrome107 🤖 schedule 🗃️ e2e/*
Committer autologie
View all properties for this run ↗︎

Test results
Tests that failed  Failures 8
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 413
View all changes introduced in this branch ↗︎

Tests for review

Failed  30-langchain.cy.ts • 2 failed tests

View Output Video

Test Artifacts
Langchain Integration > should add and use Manual Chat Trigger node together with Agent node Test Replay Screenshots Video
Langchain Integration > should execute up to Node 1 when using partial execution Test Replay Screenshots Video
Failed  19-execution.cy.ts • 5 failed tests

View Output Video

Test Artifacts
Execution > should test manual workflow Test Replay Screenshots Video
Execution > should test manual workflow stop Test Replay Screenshots Video
Execution > should test webhook workflow Test Replay Screenshots Video
Execution > should send proper payload for node rerun Test Replay Screenshots Video
Execution > should send proper payload for manual node run Test Replay Screenshots Video
Failed  233-AI-switch-to-logs-on-error.cy.ts • 1 failed test

View Output Video

Test Artifacts
AI-233 Make root node's logs pane active in case of an error in sub-nodes > should open logs tab by default when there was an error Test Replay Screenshots Video
Failed  30-editor-after-route-changes.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  29-templates.cy.ts • 0 failed tests

View Output

Test Artifacts

The first 5 failed specs are shown, see all 33 specs in Cypress Cloud.

Flakiness  e2e/24-ndv-paired-item.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > can resolve expression with paired item in multi-input node Test Replay Screenshots Video

@autologie autologie marked this pull request as ready for review May 8, 2025 08:42
@autologie autologie changed the title feat(editor): Improved log view feat(editor): Rollout improved log view May 8, 2025
Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mrge found 1 issue across 7 files. Review it in mrge.io

@@ -304,7 +304,7 @@ export const schema = {
logs_view: {
enabled: {
format: Boolean,
default: false,
default: true,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enabling a feature marked as 'temporary' by default without updating its documentation

@autologie autologie requested review from a team and MiloradFilipovic and removed request for MiloradFilipovic May 8, 2025 08:46
@Cadiac Cadiac self-requested a review May 8, 2025 09:05
@@ -141,6 +141,7 @@ watch(
type="secondary"
icon="trash"
icon-size="medium"
data-test-id="clear-execution-data-button"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this intentionally have the same data-test-id as CanvasClearExecutionDataButton ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we only show either of the two (and we'll remove the other one eventually when we'll clean up the feature flag)

Copy link
Contributor

@Cadiac Cadiac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@autologie autologie merged commit 8229b0b into master May 8, 2025
56 of 58 checks passed
@autologie autologie deleted the enable-log-view branch May 8, 2025 09:12
Copy link
Contributor

github-actions bot commented May 8, 2025

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@janober
Copy link
Member

janober commented May 12, 2025

Got released with [email protected]

ozcangungor pushed a commit to ozcangungor/n8n that referenced this pull request May 25, 2025
etobella pushed a commit to etobella/n8n that referenced this pull request May 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants