-
Notifications
You must be signed in to change notification settings - Fork 28.2k
feat(editor): Rollout improved log view #15202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mrge found 1 issue across 7 files. Review it in mrge.io
@@ -304,7 +304,7 @@ export const schema = { | |||
logs_view: { | |||
enabled: { | |||
format: Boolean, | |||
default: false, | |||
default: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enabling a feature marked as 'temporary' by default without updating its documentation
@@ -141,6 +141,7 @@ watch( | |||
type="secondary" | |||
icon="trash" | |||
icon-size="medium" | |||
data-test-id="clear-execution-data-button" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this intentionally have the same data-test-id as CanvasClearExecutionDataButton
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we only show either of the two (and we'll remove the other one eventually when we'll clean up the feature flag)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
This reverts commit 8229b0b.
Got released with |
Summary
This PR enables the improved log view by default and updates e2e tests to work with this configuration.
Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)