feat(editor): Improve manual description in nodes as tools #15373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RicardoE105
changed the title
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
packages/core/src/execution-engine/node-execution-context/utils/create-node-as-tool.ts
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
n8n-assistant
bot
added
core
RicardoE105
changed the title
...core/src/execution-engine/node-execution-context/utils/__tests__/create-node-as-tool.test.ts
Show resolved
Hide resolved
packages/core/src/execution-engine/node-execution-context/utils/create-node-as-tool.ts
Outdated
Show resolved
Hide resolved
| @@ -547,6 +548,18 @@ const valueChanged = (parameterData: IUpdateInformation) => { | |||
| nodeType, | |||
| ); | |||
|
|
|||
| if (isToolNode.value) { | |||
There was a problem hiding this comment.
Rule violated: Ensure every PR has unit tests for Vue files
Missing unit tests for the modified NodeSettings.vue component
CharlieKolb
previously approved these changes
May 14, 2025
|
✅ All Cypress E2E specs passed |
|
✅ All Cypress E2E specs passed |
RicardoE105
deleted the
ado-3097-spike-better-set-manually-defaults-for-nodes-as-tools
branch
Merged
|
Got released with |
ozcangungor
pushed a commit
to ozcangungor/n8n
that referenced
this pull request
May 25, 2025
etobella
pushed a commit
to etobella/n8n
that referenced
this pull request
May 25, 2025
Alexandero89
pushed a commit
to Alexandero89/n8n
that referenced
this pull request
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances the way manual descriptions are generated for nodes used as AI tools. It introduces a more descriptive and context-aware approach for generating tool descriptions that better reflect the actual functionality of nodes.
What's Changed
Behavior Details
New Helper Functions
Added two new utility functions in
NodeHelpers.ts:makeDescription(): Generates human-readable descriptions for nodes based on their parameters and type definition{action} in {displayName}- when operation has a defined action (e.g., "Create a new user in HTTP Request"){operation} {resource} in {displayName}- when resource and operation exist but action is missing (e.g., "create user in HTTP Request")Node's default description - as fallback when resource or operation is missing
getToolDescription(): Determines when tool descriptions should be updated and calculates the new descriptionUpdates to Node Settings Component
NodeSettings.vueto automatically update the tool description when parameters changeDemo
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/ADO-3097/spike-better-set-manually-defaults-for-nodes-as-tools
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)