fix(editor): Normalize credential data from source control #15434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
mrge reviewed 2 files and found no issues. Review PR in mrge.io.
MarcL
reviewed
May 16, 2025
packages/frontend/editor-ui/src/components/CredentialEdit/CredentialEdit.vue
Show resolved
Hide resolved
MarcL
approved these changes
May 16, 2025
|
|
|
✅ All Cypress E2E specs passed |
r00gm
deleted the
pay-2723-oauth-credential-stub-cannot-be-completed-up-on-read-only
branch
Merged
|
Got released with |
ozcangungor
pushed a commit
to ozcangungor/n8n
that referenced
this pull request
May 25, 2025
etobella
pushed a commit
to etobella/n8n
that referenced
this pull request
May 25, 2025
Alexandero89
pushed a commit
to Alexandero89/n8n
that referenced
this pull request
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Credential data pushed to source control is transformed to empty string which breaks our types and Fe checks.
Remove all empty string so at the credential type defaults kick in
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/PAY-2723/oauth-credential-stub-cannot-be-completed-up-on-read-only-instance
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)