Skip to content

fix: Fix jobs for secrets inherit #15532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025
Merged

fix: Fix jobs for secrets inherit #15532

merged 1 commit into from
May 20, 2025

Conversation

shortstacked
Copy link
Contributor

Summary

The original change wasn't passing the secrets as expected. You can't do "secrets: inherit" to a step.

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@shortstacked shortstacked requested a review from alexgrozav May 20, 2025 08:15
@shortstacked
Copy link
Contributor Author

/test-workflows

@shortstacked shortstacked changed the title fix: fixing jobs for secrets inherit fix: Fix jobs for secrets inherit May 20, 2025
Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cubic reviewed 3 files and found no issues. Review PR in cubic.dev.

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label May 20, 2025
Copy link
Contributor

✅ All Cypress E2E specs passed

@shortstacked shortstacked merged commit cf29b5f into master May 20, 2025
44 of 45 checks passed
@shortstacked shortstacked deleted the workflow-test-fix branch May 20, 2025 08:57
@shortstacked
Copy link
Contributor Author

Workflow Test Results 📊 🔴 1 Failed, ⚠️ 4 Warnings, 👍 78 Successful out of 83 total workflows.

Detail: Workflows failing: 243: Workflow contains 2 deleted data. View full workflow run

Tested Ref: workflow-variable-rename by @shortstacked

❌ Failed Tests (1)

Workflow ID Workflow Name Reason
258 Agent:auto-fix:openai Workflow contains 2 deleted data.

⚠️ Warnings (4)

Workflow ID Workflow Name Reason
237 BasicLLMChain:AzureChat Workflow contains new data that previously did not exist.
35 Slack:User:getPresence info:UserProfile:get update... Workflow contains new data that previously did not exist.
257 Agent:auto-fix:anthropic Workflow contains new data that previously did not exist.
53 ConvertKit:CustomField:create getAll update delete... Workflow contains new data that previously did not exist.

@shortstacked
Copy link
Contributor Author

/test-workflow

despairblue pushed a commit that referenced this pull request May 21, 2025
ozcangungor pushed a commit to ozcangungor/n8n that referenced this pull request May 25, 2025
etobella pushed a commit to etobella/n8n that referenced this pull request May 25, 2025
@github-actions github-actions bot mentioned this pull request May 26, 2025
@janober
Copy link
Member

janober commented May 26, 2025

Got released with [email protected]

Alexandero89 pushed a commit to Alexandero89/n8n that referenced this pull request May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants