fix(core): handle run-commands targets with no commands

Author: FrozenPandaz

packages/nx/src/executors/run-commands/run-commands.impl.spec.ts

@@ -22,6 +22,18 @@ describe('Run Commands', () => {
     jest.clearAllMocks();
   });
 
+  it('should handle empty commands array', async () => {
+    const result = await runCommands(
+      {
+        commands: [],
+        __unparsed__: [],
+      },
+      context
+    );
+    expect(result.success).toEqual(true);
+    expect(result.terminalOutput).toEqual('');
+  });
+
   it('should interpolate provided --args', async () => {
     const f = fileSync().name;
     const result = await runCommands(

packages/nx/src/executors/run-commands/run-commands.impl.ts

@@ -2,6 +2,7 @@ import * as yargsParser from 'yargs-parser';
 import { ExecutorContext } from '../../config/misc-interfaces';
 import { isTuiEnabled } from '../../tasks-runner/is-tui-enabled';
 import { PseudoTerminal } from '../../tasks-runner/pseudo-terminal';
+import { NoopChildProcess } from '../../tasks-runner/running-tasks/noop-child-process';
 import {
   ParallelRunningTasks,
   runSingleCommandWithPseudoTerminal,
@@ -117,6 +118,11 @@ export async function runCommands(
     );
   }
 
+  // Handle empty commands array - return immediately with success
+  if (normalized.commands.length === 0) {
+    return new NoopChildProcess({ code: 0, terminalOutput: '' });
+  }
+
   const isSingleCommand = normalized.commands.length === 1;
 
   const usePseudoTerminal =

packages/nx/src/tasks-runner/running-tasks/noop-child-process.ts

@@ -1,8 +1,16 @@
-import { Serializable } from 'child_process';
 import { RunningTask } from './running-task';
 
 export class NoopChildProcess implements RunningTask {
-  constructor(private results: { code: number; terminalOutput: string }) {}
+  private exitCallbacks: Array<(code: number, terminalOutput: string) => void> =
+    [];
+  private outputCallbacks: Array<(terminalOutput: string) => void> = [];
+
+  constructor(private results: { code: number; terminalOutput: string }) {
+    // Call exit callbacks asynchronously to simulate task completion
+    for (const cb of this.exitCallbacks) {
+      cb(this.results.code, this.results.terminalOutput);
+    }
+  }
 
   send(): void {}
 
@@ -14,7 +22,11 @@ export class NoopChildProcess implements RunningTask {
     return;
   }
 
-  onExit(cb: (code: number) => void): void {
-    cb(this.results.code);
+  onExit(cb: (code: number, terminalOutput: string) => void): void {
+    cb(this.results.code, this.results.terminalOutput);
+  }
+
+  onOutput(cb: (terminalOutput: string) => void): void {
+    cb(this.results.terminalOutput);
   }
 }