Issue with cider complete

[benjamin-asdf]

Hi,
my issue is for completing when the prefix is "foo/" (with / in the name). Somehow orderless-filter only decides to call the completing function with the empty string but never with "foo/" which would yield the correct completions.
Do you know why and can you help me fix this in some way?
Thanks for the awesome package.

If you need a repro I can check if I can make a minimal one.

[minad]

See clojure-emacs/cider#3019

[minad]

The issue can be fixed by using a style dispatcher which adds a ^ before the first component. Alternatively combine the basic completion style with orderless.

793eb0e

[benjamin-asdf]

Will check thanks

[benjamin-asdf]

(defun mm/cider-style-dispatcher
    (component idx count)
  (when
      (eq idx 0)
    (concat "^" component)))

(setq
 orderless-style-dispatchers
 '(mm/cider-style-dispatcher))

tried like this but it did not do the trick yet. Adding 'basic to completion styles does help though.

[minad]

If basic works then the orderless style dispatcher you wrote should work too. Please check if you use the newest version etc and if indeed orderless passes the first component to the completion function instead of the empty string as it did before.

[benjamin-asdf]

Yea cider-complete still get's called with empty string on commit 62f71c3.
(+ using the style dispatcher I posted)

[minad]

Yea cider-complete still get's called with empty string on commit 62f71c3

Your dispatcher is incorrect. It must return a pair of orderless style and transformed pattern. ~~~ ;; Dispatcher (defun orderless-prefix-dispatch (component idx _total) (and (= idx 0) `(orderless-regexp . ,(concat "^" (regexp-quote component))))) ;; Configure (setq orderless-style-dispatchers '(orderless-prefix-dispatch) completion-styles '(orderless) completion-category-defaults nil completion-category-overrides nil) ;; Check (completing-read "Prompt: " (completion-table-dynamic (lambda (input) (list input)))) ~~~

[benjamin-asdf]

Nice thanks a lot. Now I only need a way to only enable this for cider completions.
Setting it buffer local in cider buffers only works halfway because then it's not set for completion-at-point in the minibuffer I guess.

I achieved the above with something along those lines:

(defun mm/patch-orderless-style ()
  (setq-local
   orderless-style-dispatchers
'(orderless-prefix-dispatch)))


(defun my-completion-at-point ()
  (interactive)
    (let ((minibuffer-setup-hook
	   (if cider-mode
	       (append
		minibuffer-setup-hook
		'(mm/patch-orderless-style))
	     minibuffer-setup-hook)))
      (completion-at-point)))

[abcdw]

I can't reproduce it. Can someone else check it the problem is still present?

Ok, I just had a basic as a fallback style.

[minad]

Using basic as fallback is perfectly fine for dynamic tables.

[oantolin]

I think the current recommendation in the documentaton to use basic as a fallback is godd enough to close this issue, no? If not, we can reopen.

[abcdw]

I did the following trick, which is a little dirty, but works quite well: clojure-emacs/cider#3019 (comment)