Prevent to hit rpmlint_log action if no builds yet #17966
Conversation
| = render partial: 'no_repositories', locals: { project: project } | ||
| - else | ||
| - if repository_list.empty? | ||
| = render partial: 'no_repositories', locals: { project: project } |
There was a problem hiding this comment.
This is not really true right? Just because you have no buildresults does not mean you have no repositories....
For instance this was one of the packages where this came from:
https://build.opensuse.org/package/show/SUSE:SLE-15-SP3:GA/suse-prime.15937
The project has plenty of repositories defined.
There was a problem hiding this comment.
Kinda. Your picture is pretty much correct, it's the naming of the variables and the partial that is tricky.
repository_list comes from the package_controller and it is an extracted list of repositories the ones if there is a build result of it. The differentiation for when there are no build results or there are really not even repositories define it is handled internally in the no_repositories partial.
I fully agree with you if you say "then, let's rename and refactor better because as it is right now it's completely misleading", but because this partial is used by multiple code path I'd rather postpone it. Tracked here
There was a problem hiding this comment.
Initial refactoring/renaming step available here --> #17970 , just to give a hint what the partial stands for
Fixes #17960
The changes look quite complex but it's just because of the indentation. It only wraps and prevents to run the js call in case of the condition
repository_list.empty?that means that there are no builds yet available despite repositories are configured already in the related project.Depends on #17970