Skip to content

Add time namespace / TimeOffsets check and helper #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add time namespace / TimeOffsets check and helper #784

wants to merge 1 commit into from
+21 −1

Conversation

champtar
Copy link

Fixes #783

@champtar champtar requested a review from a team as a code owner January 23, 2025 03:38
@champtar
Copy link
Author

champtar commented Feb 3, 2025

@tianon @kolyshkin @cyphar ping as you are the last 3 to have merged code here

kolyshkin
kolyshkin previously approved these changes Mar 1, 2025
View reviewed changes
Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolyshkin kolyshkin added this to the v0.10.0 milestone Mar 1, 2025
cyphar
cyphar requested changes May 23, 2025
View reviewed changes
Copy link
Member

@cyphar cyphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This requires timeOffsets support to really be usable. time namespaces without an offset aren't really any different to just using the host timens.

@champtar
Copy link
Author

@cyphar added a check and an helper, is this what you were thinking ?
If not can you point at exactly what I should add ?

@champtar champtar changed the title Add time namespace Add time namespace / TimeOffsets check and helper May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyphar cyphar cyphar requested changes

@kolyshkin kolyshkin kolyshkin left review comments

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging this pull request may close these issues.

time namespace missing
3 participants
@champtar @cyphar @kolyshkin