Skip to content

Commit be6ceb7

Browse files
committed
Use CRD introspection flag to enable tool calling
1 parent 515518c commit be6ceb7

File tree

4 files changed

+5
-37
lines changed

4 files changed

+5
-37
lines changed

tests/config/operator_install/olsconfig.crd.azure_openai_tool_calling.yaml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,4 @@ spec:
3333
- name: bar_filter
3434
pattern: '\b(?:bar)\b'
3535
replaceWith: "openshift"
36-
mcp_servers:
37-
- name: openshift
38-
transport: stdio
39-
stdio:
40-
command: python
41-
args:
42-
- ./mcp_local/openshift.py
36+
introspectionEnabled: true

tests/config/operator_install/olsconfig.crd.openai_tool_calling.yaml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,4 @@ spec:
3131
- name: bar_filter
3232
pattern: '\b(?:bar)\b'
3333
replaceWith: "openshift"
34-
mcp_servers:
35-
- name: openshift
36-
transport: stdio
37-
stdio:
38-
command: python
39-
args:
40-
- ./mcp_local/openshift.py
34+
introspectionEnabled: true

tests/config/operator_install/olsconfig.crd.watsonx_tool_calling.yaml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,4 @@ spec:
3232
- name: bar_filter
3333
pattern: '\b(?:bar)\b'
3434
replaceWith: "openshift"
35-
mcp_servers:
36-
- name: openshift
37-
transport: stdio
38-
stdio:
39-
command: python
40-
args:
41-
- ./mcp_local/openshift.py
35+
introspectionEnabled: true

tests/e2e/utils/ols_installer.py

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ def create_and_config_sas() -> tuple[str, str]:
6969
return token, metrics_token
7070

7171

72-
def update_ols_config(tool_calling_enabled: bool) -> None:
72+
def update_ols_config() -> None:
7373
"""Create the ols config configmap with log and collector config for e2e tests.
7474
7575
Returns:
@@ -84,20 +84,6 @@ def update_ols_config(tool_calling_enabled: bool) -> None:
8484
# logs beying redacted/removed completely - we need log at info level
8585
olsconfig["ols_config"]["logging_config"]["lib_log_level"] = "INFO"
8686

87-
if tool_calling_enabled:
88-
olsconfig["mcp_servers"] = [
89-
{
90-
"name": "openshift",
91-
"transport": "stdio",
92-
"stdio": {
93-
"command": "python3.11",
94-
"args": [
95-
"/app-root/mcp_local/openshift.py",
96-
],
97-
},
98-
}
99-
]
100-
10187
# add collector config for e2e tests
10288
olsconfig["user_data_collector_config"] = {
10389
"data_storage": "/app-root/ols-user-data",
@@ -459,7 +445,7 @@ def install_ols() -> tuple[str, str, str]: # pylint: disable=R0915, R0912 # no
459445
"0",
460446
]
461447
)
462-
update_ols_config(tool_calling_enabled)
448+
update_ols_config()
463449
# scale the ols app server up
464450
cluster_utils.run_oc(
465451
[

0 commit comments

Comments
 (0)