add tests

Author: qJkee

internal/controllers/vgmanager/controller_test.go

@@ -82,6 +82,7 @@ var _ = Describe("vgmanager controller", func() {
 			It("should handle LVMD edge cases correctly", testLVMD)
 			It("should handle thin pool creation correctly", testThinPoolCreation)
 			It("should handle thin pool extension cases correctly", testThinPoolExtension)
+			It("should handle metadata size extension correctly", testMetadataSizeExtension)
 		})
 		Context("event tests", func() {
 			It("should correctly emit events", testEvents)
@@ -703,6 +704,36 @@ func testLVMD(ctx context.Context) {
 	Expect(err).To(HaveOccurred(), "should error if lvmd config cannot be saved")
 }
 
+func testMetadataSizeExtension(ctx context.Context) {
+	r := &Reconciler{Scheme: scheme.Scheme}
+	logger := zap.New(zap.WriteTo(GinkgoWriter), zap.UseDevMode(true))
+	ctx = log.IntoContext(ctx, logger)
+	mockLVM := lvmmocks.NewMockLVM(GinkgoT())
+	r.LVM = mockLVM
+
+	cfg := lvmv1alpha1.ThinPoolConfig{
+		Name:                          "test",
+		MetadataSizeCalculationPolicy: lvmv1alpha1.MetadataSizePolicyHost,
+	}
+
+	By("skip metadata extension when policy set to Host")
+	err := r.verifyMetadataSize(ctx, "vg1", cfg.Name, "1024b", convertMetadataSize(&cfg))
+	Expect(err).NotTo(HaveOccurred(), "should not error if metadata size calculation policy is Host")
+
+	By("skip metadata extension when metadata size is same")
+	cfg.MetadataSizeCalculationPolicy = lvmv1alpha1.MetadataSizePolicyStatic
+	cfg.MetadataSize = ptr.To(resource.MustParse("1Mi"))
+	err = r.verifyMetadataSize(ctx, "vg1", cfg.Name, fmt.Sprintf("%vb", cfg.MetadataSize.Value()), convertMetadataSize(&cfg))
+	Expect(err).NotTo(HaveOccurred(), "should not error because metadata size is the same")
+
+	By("extend metadata size when provided is bigger than actual")
+	oldSize := cfg.MetadataSize
+	cfg.MetadataSize = ptr.To(resource.MustParse("1Gi"))
+	mockLVM.EXPECT().ExtendThinPoolMetadata(ctx, cfg.Name, "vg1", cfg.MetadataSize.Value()).Return(nil).Once()
+	err = r.verifyMetadataSize(ctx, "vg1", cfg.Name, fmt.Sprintf("%vb", oldSize.Value()), convertMetadataSize(&cfg))
+	Expect(err).NotTo(HaveOccurred(), "should not error when metadata extended")
+}
+
 func testThinPoolExtension(ctx context.Context) {
 	r := &Reconciler{Scheme: scheme.Scheme}
 	logger := zap.New(zap.WriteTo(GinkgoWriter), zap.UseDevMode(true))

internal/controllers/vgmanager/lvm/lvm_test.go

@@ -449,7 +449,7 @@ func TestHostLVM_CreateLV(t *testing.T) {
 				if tt.execErr {
 					return fmt.Errorf("mocked error")
 				}
-				assert.ElementsMatch(t, args, []string{"-l", fmt.Sprintf("%d%%FREE", tt.sizePercent), "-c", fmt.Sprintf("%vb", tt.chunkSizeBytes), "-Z", "y", "-T", fmt.Sprintf("%s/%s", tt.vgName, tt.lvName, "--poolmetadatasize", fmt.Sprintf("%vb", tt.metadataSizeBytes))})
+				assert.ElementsMatch(t, args, []string{"-l", fmt.Sprintf("%d%%FREE", tt.sizePercent), "-c", fmt.Sprintf("%vb", tt.chunkSizeBytes), "-Z", "y", "-T", fmt.Sprintf("%s/%s", tt.vgName, tt.lvName), "--poolmetadatasize", fmt.Sprintf("%vb", tt.metadataSizeBytes)})
 				return nil
 			}}