Skip to content

Help doc for preference is buggy #4654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
valaparthvi opened this issue Apr 23, 2021 · 0 comments · Fixed by #4471
Closed

Help doc for preference is buggy #4654

valaparthvi opened this issue Apr 23, 2021 · 0 comments · Fixed by #4471
Assignees
@valaparthvi
Labels
good first issue Denotes an issue ready for a new contributor. Maintainers will help mentor new contributors. kind/bug Categorizes issue or PR as related to a bug.

Comments

@valaparthvi
Copy link
Contributor

valaparthvi commented Apr 23, 2021 •
edited
Loading

/kind bug

What versions of software are you using?

Operating System:
Fedora 32

Output of odo version:
odo v2.1.0 (40a90e1)
Server: https://192.168.42.43:8443
Kubernetes: v1.11.0+d4cacc0

How did you run odo exactly?

odo preference --help
odo preference unset --help

Actual behavior

odo preference --help

  ...
  ...
  odo preference set %!s(BADINDEX) true

  # Unset a preference value in the global preference
  ...
  ...
  odo preference unset %!s(BADINDEX)

odo preference unset --help

Available Global Parameters:
 ...
 UpdateNotification - Flag to control if an update notification is shown or not (Default: true)
 %!s(BADINDEX)

Expected behavior

There should be no BADINDEX error.

Any logs, error output, etc?
@valaparthvi valaparthvi added the good first issue Denotes an issue ready for a new contributor. Maintainers will help mentor new contributors. label Apr 23, 2021
@valaparthvi valaparthvi self-assigned this Apr 23, 2021
@valaparthvi valaparthvi linked a pull request Apr 23, 2021 that will close this issue
Refactor help examples to use go templates #4471
Merged
2 tasks
@valaparthvi valaparthvi mentioned this issue Apr 23, 2021
Merged
2 tasks
@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valaparthvi valaparthvi

Labels
good first issue Denotes an issue ready for a new contributor. Maintainers will help mentor new contributors. kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor help examples to use go templates valaparthvi/odo
2 participants
@valaparthvi @openshift-ci-robot