Skip to content

Commit df793e9

Browse files
committed
Remove NoVolumeNodeConflict from 3.9+
1 parent 1a9a61b commit df793e9

File tree

4 files changed

+33
-262
lines changed

4 files changed

+33
-262
lines changed

roles/lib_utils/lookup_plugins/openshift_master_facts_default_predicates.py

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ def run(self, terms, variables=None, regions_enabled=True, short_version=None,
114114
{'name': 'CheckNodeDiskPressure'},
115115
])
116116

117-
if short_version in ['3.7', '3.8', '3.9', '3.10']:
117+
if short_version in ['3.7', '3.8']:
118118
predicates.extend([
119119
{'name': 'NoVolumeZoneConflict'},
120120
{'name': 'MaxEBSVolumeCount'},
@@ -129,6 +129,21 @@ def run(self, terms, variables=None, regions_enabled=True, short_version=None,
129129
{'name': 'NoVolumeNodeConflict'},
130130
])
131131

132+
if short_version in ['3.9', '3.10']:
133+
predicates.extend([
134+
{'name': 'NoVolumeZoneConflict'},
135+
{'name': 'MaxEBSVolumeCount'},
136+
{'name': 'MaxGCEPDVolumeCount'},
137+
{'name': 'MaxAzureDiskVolumeCount'},
138+
{'name': 'MatchInterPodAffinity'},
139+
{'name': 'NoDiskConflict'},
140+
{'name': 'GeneralPredicates'},
141+
{'name': 'PodToleratesNodeTaints'},
142+
{'name': 'CheckNodeMemoryPressure'},
143+
{'name': 'CheckNodeDiskPressure'},
144+
{'name': 'CheckVolumeBinding'},
145+
])
146+
132147
if regions_enabled:
133148
region_predicate = {
134149
'name': 'Region',

roles/lib_utils/test/openshift_master_facts_default_predicates_tests.py

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,23 @@
7171
{'name': 'NoVolumeNodeConflict'},
7272
]
7373

74-
DEFAULT_PREDICATES_3_10 = DEFAULT_PREDICATES_3_9 = DEFAULT_PREDICATES_3_8 = DEFAULT_PREDICATES_3_7
74+
DEFAULT_PREDICATES_3_8 = DEFAULT_PREDICATES_3_7
75+
76+
DEFAULT_PREDICATES_3_9 = [
77+
{'name': 'NoVolumeZoneConflict'},
78+
{'name': 'MaxEBSVolumeCount'},
79+
{'name': 'MaxGCEPDVolumeCount'},
80+
{'name': 'MaxAzureDiskVolumeCount'},
81+
{'name': 'MatchInterPodAffinity'},
82+
{'name': 'NoDiskConflict'},
83+
{'name': 'GeneralPredicates'},
84+
{'name': 'PodToleratesNodeTaints'},
85+
{'name': 'CheckNodeMemoryPressure'},
86+
{'name': 'CheckNodeDiskPressure'},
87+
{'name': 'CheckVolumeBinding'},
88+
]
89+
90+
DEFAULT_PREDICATES_3_10 = DEFAULT_PREDICATES_3_9
7591

7692
REGION_PREDICATE = {
7793
'name': 'Region',

roles/openshift_master_facts/lookup_plugins/openshift_master_facts_default_predicates.py

Lines changed: 0 additions & 143 deletions
This file was deleted.

roles/openshift_master_facts/lookup_plugins/openshift_master_facts_default_priorities.py

Lines changed: 0 additions & 117 deletions
This file was deleted.

0 commit comments

Comments
 (0)