Skip to content

Commit 5104713

Browse files
committed
File path input should always be readonly
The text input for uploading files should always be readonly since you can't type a file name. You have to use the browse button or drag and drop.
1 parent 690def0 commit 5104713

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

app/views/directives/osc-file-input.html

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
readonly
1111
ng-show="supportsFileUpload"
1212
ng-disabled="disabled"
13-
ng-readonly="readonly"
1413
ng-attr-aria-describedby="{{helpText ? helpID : undefined}}">
1514
<span class="input-group-btn">
1615
<span class="btn btn-default btn-file" ng-show="supportsFileUpload" ng-attr-disabled="{{ (disabled || readonly) || undefined }}">

dist/scripts/templates.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7734,7 +7734,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
77347734
"<p>Drop file here</p>\n" +
77357735
"</div>\n" +
77367736
"<div class=\"input-group\">\n" +
7737-
"<input type=\"text\" class=\"form-control\" ng-model=\"fileName\" readonly=\"readonly\" ng-show=\"supportsFileUpload\" ng-disabled=\"disabled\" ng-readonly=\"readonly\" ng-attr-aria-describedby=\"{{helpText ? helpID : undefined}}\">\n" +
7737+
"<input type=\"text\" class=\"form-control\" ng-model=\"fileName\" readonly=\"readonly\" ng-show=\"supportsFileUpload\" ng-disabled=\"disabled\" ng-attr-aria-describedby=\"{{helpText ? helpID : undefined}}\">\n" +
77387738
"<span class=\"input-group-btn\">\n" +
77397739
"<span class=\"btn btn-default btn-file\" ng-show=\"supportsFileUpload\" ng-attr-disabled=\"{{ (disabled || readonly) || undefined }}\">\n" +
77407740
"Browse&hellip;\n" +

0 commit comments

Comments
 (0)