Skip to content

Commit 52d21dc

Browse files
committed
deprecate the imagestream.spec.DockerImageRepository field
1 parent bb340c5 commit 52d21dc

File tree

3 files changed

+8
-3
lines changed

3 files changed

+8
-3
lines changed

pkg/image/apis/image/types.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -217,6 +217,8 @@ type ImageStreamSpec struct {
217217
// lookupPolicy controls how other resources reference images within this namespace.
218218
LookupPolicy ImageLookupPolicy
219219
// Optional, if specified this stream is backed by a Docker repository on this server
220+
// Deprecated: This field is deprecated as of v3.7 and will be removed in a future release
221+
// Specify the source for the tags to be imported in each tag via the spec.tags.from reference instead.
220222
DockerImageRepository string
221223
// Tags map arbitrary string values to specific image locators
222224
Tags map[string]TagReference

pkg/image/apis/image/v1/types.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,6 +173,8 @@ type ImageStreamSpec struct {
173173
// lookupPolicy controls how other resources reference images within this namespace.
174174
LookupPolicy ImageLookupPolicy `json:"lookupPolicy,omitempty" protobuf:"bytes,3,opt,name=lookupPolicy"`
175175
// dockerImageRepository is optional, if specified this stream is backed by a Docker repository on this server
176+
// Deprecated: This field is deprecated as of v3.7 and will be removed in a future release
177+
// Specify the source for the tags to be imported in each tag via the spec.tags.from reference instead.
176178
DockerImageRepository string `json:"dockerImageRepository,omitempty" protobuf:"bytes,1,opt,name=dockerImageRepository"`
177179
// tags map arbitrary string values to specific image locators
178180
Tags []TagReference `json:"tags,omitempty" protobuf:"bytes,2,rep,name=tags"`
@@ -195,7 +197,8 @@ type TagReference struct {
195197
Name string `json:"name" protobuf:"bytes,1,opt,name=name"`
196198
// Annotations associated with images using this tag
197199
Annotations map[string]string `json:"annotations" protobuf:"bytes,2,rep,name=annotations"`
198-
// From is a reference to an image stream tag or image stream this tag should track
200+
// Optional; if specified, a reference to another image that this tag should point to. Valid values
201+
// are ImageStreamTag, ImageStreamImage, and DockerImage.
199202
From *kapi.ObjectReference `json:"from,omitempty" protobuf:"bytes,3,opt,name=from"`
200203
// Reference states if the tag will be imported. Default value is false, which means the tag will be imported.
201204
Reference bool `json:"reference,omitempty" protobuf:"varint,4,opt,name=reference"`

pkg/openapi/zz_generated.openapi.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6149,7 +6149,7 @@ func GetOpenAPIDefinitions(ref openapi.ReferenceCallback) map[string]openapi.Ope
61496149
},
61506150
"dockerImageRepository": {
61516151
SchemaProps: spec.SchemaProps{
6152-
Description: "dockerImageRepository is optional, if specified this stream is backed by a Docker repository on this server",
6152+
Description: "dockerImageRepository is optional, if specified this stream is backed by a Docker repository on this server Deprecated: This field is deprecated as of v3.7 and will be removed in a future release Specify the source for the tags to be imported in each tag via the spec.tags.from reference instead.",
61536153
Type: []string{"string"},
61546154
Format: "",
61556155
},
@@ -6729,7 +6729,7 @@ func GetOpenAPIDefinitions(ref openapi.ReferenceCallback) map[string]openapi.Ope
67296729
},
67306730
"from": {
67316731
SchemaProps: spec.SchemaProps{
6732-
Description: "From is a reference to an image stream tag or image stream this tag should track",
6732+
Description: "Optional; if specified, a reference to another image that this tag should point to. Valid values are ImageStreamTag, ImageStreamImage, and DockerImage.",
67336733
Ref: ref("k8s.io/kubernetes/pkg/api/v1.ObjectReference"),
67346734
},
67356735
},

0 commit comments

Comments
 (0)