make binding poll function clone binding (#1550)

Author: kibbles-n-bytes

pkg/controller/controller_binding.go

@@ -180,12 +180,7 @@ func (c *controller) reconcileServiceBinding(binding *v1beta1.ServiceBinding) er
 	glog.V(6).Info(pcb.Messagef(`beginning to process resourceVersion: %v`, binding.ResourceVersion))
 
 	if binding.Status.AsyncOpInProgress {
-		toUpdate, err := makeServiceBindingClone(binding)
-		if err != nil {
-			return err
-		}
-
-		return c.pollServiceBinding(toUpdate)
+		return c.pollServiceBinding(binding)
 	}
 
 	if isServiceBindingFailed(binding) && binding.ObjectMeta.DeletionTimestamp == nil && !binding.Status.OrphanMitigationInProgress {
@@ -1236,6 +1231,11 @@ func (c *controller) pollServiceBinding(binding *v1beta1.ServiceBinding) error {
 
 	glog.V(4).Infof(pcb.Message("Processing"))
 
+	binding, err := makeServiceBindingClone(binding)
+	if err != nil {
+		return err
+	}
+
 	instance, err := c.instanceLister.ServiceInstances(binding.Namespace).Get(binding.Spec.ServiceInstanceRef.Name)
 	if err != nil {
 		return fmt.Errorf("could not get instance for ServiceBinding %v/%v", binding.Namespace, binding.Name)