Skip to content

Commit ed83a54

Browse files
committed
only set PodManifestConfig flags if explicitly specified
1 parent b8d718c commit ed83a54

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

pkg/cmd/server/kubernetes/node/options/options.go

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,9 @@ func ComputeKubeletFlags(startingArgs map[string][]string, options configapi.Nod
3030
imageTemplate.Format = options.ImageConfig.Format
3131
imageTemplate.Latest = options.ImageConfig.Latest
3232

33-
path := ""
34-
var fileCheckInterval int64
3533
if options.PodManifestConfig != nil {
36-
path = options.PodManifestConfig.Path
37-
fileCheckInterval = options.PodManifestConfig.FileCheckIntervalSeconds
34+
setIfUnset(args, "pod-manifest-path", options.PodManifestConfig.Path)
35+
setIfUnset(args, "file-check-frequency", fmt.Sprintf("%ds", options.PodManifestConfig.FileCheckIntervalSeconds))
3836
}
3937
kubeAddressStr, kubePortStr, err := net.SplitHostPort(options.ServingInfo.BindAddress)
4038
if err != nil {
@@ -44,7 +42,6 @@ func ComputeKubeletFlags(startingArgs map[string][]string, options configapi.Nod
4442
setIfUnset(args, "address", kubeAddressStr)
4543
setIfUnset(args, "port", kubePortStr)
4644
setIfUnset(args, "kubeconfig", options.MasterKubeConfig)
47-
setIfUnset(args, "pod-manifest-path", path)
4845
setIfUnset(args, "root-dir", options.VolumeDirectory)
4946
setIfUnset(args, "node-ip", options.NodeIP)
5047
setIfUnset(args, "hostname-override", options.NodeName)
@@ -61,7 +58,6 @@ func ComputeKubeletFlags(startingArgs map[string][]string, options configapi.Nod
6158
setIfUnset(args, "host-pid-sources", "api", "file")
6259
setIfUnset(args, "host-ipc-sources", "api", "file")
6360
setIfUnset(args, "http-check-frequency", "0s") // no remote HTTP pod creation access
64-
setIfUnset(args, "file-check-frequency", fmt.Sprintf("%ds", fileCheckInterval))
6561
setIfUnset(args, "pod-infra-container-image", imageTemplate.ExpandOrDie("pod"))
6662
setIfUnset(args, "max-pods", "250")
6763
setIfUnset(args, "cgroup-driver", "systemd")

0 commit comments

Comments
 (0)