Merge pull request #19976 from wozniakjan/bz1461324/verify-signature

openshift-merge-robot · web-flow · commit f5b16cbb2baf · 2018-06-19T17:34:16.000-07:00
Bug 1461324 - Log image changes on verify-image-signature without --save
diff --git a/pkg/oc/admin/image/verify-signature.go b/pkg/oc/admin/image/verify-signature.go
@@ -244,6 +244,8 @@ func (o VerifyImageSignatureOptions) Run() error {
 	if o.Save || o.RemoveAll {
 		_, err := o.ImageClient.Images().Update(img)
 		return err
+	} else {
+		fmt.Fprintf(o.Out, "Neither --save nor --remove-all were passed, image %q not updated to %v\n", o.InputImage, img)
 	}
 	return nil
 }

Original file line number	Diff line number	Diff line change
`@@ -244,6 +244,8 @@ func (o VerifyImageSignatureOptions) Run() error {`
`244`	`244`	`if o.Save \|\| o.RemoveAll {`
`245`	`245`	`_, err := o.ImageClient.Images().Update(img)`
`246`	`246`	`return err`
	`247`	`+ } else {`
	`248`	`+ fmt.Fprintf(o.Out, "Neither --save nor --remove-all were passed, image %q not updated to %v\n", o.InputImage, img)`
`247`	`249`	`}`
`248`	`250`	`return nil`
`249`	`251`	`}`