Skip to content

Commit f1e3476

Browse files
committed
kata installation should not watch the 'worker' MCP state
When the MCO migrates nodes between pools, the target pool enters the Updating state and has nodes gradually added to it as they are updated and rebooted while the source pool is drained by simply setting its machine count to the desired value at once and never leaves the Updated state. Because the "worker" pool is the source pool in kata installation, it follows that nothing can be gained by watching its status. Normally it doesn't hurt either but if "worker" is Updating already for some unrelated reason when kata installation is starting, it throws off the isInstallationInProgress detection and thus the whole installation flow. Signed-off-by: Pavel Mores <[email protected]>
1 parent e0340d9 commit f1e3476

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

controllers/openshift_controller.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1267,7 +1267,7 @@ func (r *KataConfigOpenShiftReconciler) processKataConfigInstallRequest() (ctrl.
12671267
r.setInProgressConditionToInstalling()
12681268
}
12691269

1270-
isInstallationInProgress := r.isMcpUpdating(machinePool) || (!isConvergedCluster && r.isMcpUpdating("worker"))
1270+
isInstallationInProgress := r.isMcpUpdating(machinePool)
12711271

12721272
// Create kata-oc MCP only if it's not a converged cluster
12731273
if !isConvergedCluster {

0 commit comments

Comments
 (0)