NO-JIRA: match external topology

Author: neisw

pkg/variantregistry/ocp.go

@@ -731,10 +731,21 @@ func setTopology(_ logrus.FieldLogger, variants map[string]string, jobName strin
 		{"-hypershift", "external"},
 		{"-hcp", "external"},
 		{"_hcp", "external"},
+		{"-external", "external"},
 		{"-compact", "compact"},
 		{"-microshift", "microshift"},
 	}
 
+	// the use of external-lb in these cases do not apply to topology so drop them out from evaluation
+	ignorePatterns := []string{"-external-lb-", "-externallb"}
+	for _, ignore := range ignorePatterns {
+		replace := "-"
+		if ignore[len(ignore)-1] != '-' {
+			replace = ""
+		}
+		jobNameLower = strings.ReplaceAll(jobNameLower, ignore, replace)
+	}
+
 	for _, entry := range topologyPatterns {
 		if strings.Contains(jobNameLower, entry.substring) {
 			variants[VariantTopology] = entry.topology