fix(node:http) fix socket detach (#19052)

Co-authored-by: cirospaciari <[email protected]>

Author: cirospaciari

src/js/node/http.ts

@@ -1140,6 +1140,9 @@ const ServerPrototype = {
             http_res.detachSocket(socket);
             return;
           }
+          if (http_res.socket) {
+            http_res.on("finish", http_res.detachSocket.bind(http_res, socket));
+          }
 
           const { reject, resolve, promise } = $newPromiseCapability(Promise);
           resolveFunction = resolve;

test/js/third_party/next-auth/fixture/.gitignore

@@ -0,0 +1,41 @@
+# See https://help.github.com/articles/ignoring-files/ for more about ignoring files.
+
+# dependencies
+/node_modules
+/.pnp
+.pnp.*
+.yarn/*
+!.yarn/patches
+!.yarn/plugins
+!.yarn/releases
+!.yarn/versions
+
+# testing
+/coverage
+
+# next.js
+/.next/
+/out/
+
+# production
+/build
+
+# misc
+.DS_Store
+*.pem
+
+# debug
+npm-debug.log*
+yarn-debug.log*
+yarn-error.log*
+.pnpm-debug.log*
+
+# env files (can opt-in for committing if needed)
+.env*
+
+# vercel
+.vercel
+
+# typescript
+*.tsbuildinfo
+next-env.d.ts

test/js/third_party/next-auth/fixture/eslint.config.mjs

@@ -0,0 +1,14 @@
+import { FlatCompat } from "@eslint/eslintrc";
+import { dirname } from "path";
+import { fileURLToPath } from "url";
+
+const __filename = fileURLToPath(import.meta.url);
+const __dirname = dirname(__filename);
+
+const compat = new FlatCompat({
+  baseDirectory: __dirname,
+});
+
+const eslintConfig = [...compat.extends("next/core-web-vitals", "next/typescript")];
+
+export default eslintConfig;

test/js/third_party/next-auth/fixture/next.config.ts

@@ -0,0 +1,10 @@
+import type { NextConfig } from "next";
+
+const nextConfig: NextConfig = {
+  /* config options here */
+  eslint: {
+    ignoreDuringBuilds: true,
+  },
+};
+
+export default nextConfig;

test/js/third_party/next-auth/fixture/package.json

@@ -0,0 +1,28 @@
+{
+  "name": "next",
+  "version": "0.1.0",
+  "private": true,
+  "scripts": {
+    "dev": "next dev",
+    "build": "next build",
+    "start": "next start",
+    "lint": "next lint"
+  },
+  "dependencies": {
+    "next": "15.3.0",
+    "next-auth": "5.0.0-beta.25",
+    "react": "19.0.0",
+    "react-dom": "19.0.0"
+  },
+  "devDependencies": {
+    "@eslint/eslintrc": "^3",
+    "@tailwindcss/postcss": "^4",
+    "@types/node": "^20",
+    "@types/react": "^19",
+    "@types/react-dom": "^19",
+    "eslint": "^9",
+    "eslint-config-next": "15.3.0",
+    "tailwindcss": "^4",
+    "typescript": "^5"
+  }
+}

test/js/third_party/next-auth/fixture/postcss.config.mjs

@@ -0,0 +1,5 @@
+const config = {
+  plugins: ["@tailwindcss/postcss"],
+};
+
+export default config;

test/js/third_party/next-auth/fixture/public/file.svg

@@ -0,0 +1,63 @@
+import net from "net";
+import { parse } from "url";
+import http from "http";
+import next from "next";
+import { expect } from "bun:test";
+function test(port) {
+  const payload = Buffer.from(JSON.stringify({ message: "bun" }));
+
+  function sendRequest(socket) {
+    const { promise, resolve } = Promise.withResolvers();
+    let first = true;
+    socket.on("data", data => {
+      if (first) {
+        first = false;
+        const statusText = data.toString("utf8").split("HTTP/1.1")[1]?.split("\r\n")[0]?.trim();
+        try {
+          expect(statusText).toBe("200 OK");
+          resolve();
+        } catch (err) {
+          console.error(err);
+          process.exit(1);
+        }
+      }
+    });
+    socket.write(
+      `POST /api/echo HTTP/1.1\r\nHost: localhost:8080\r\nConnection: keep-alive\r\nContent-Length: ${payload.byteLength}\r\n\r\n`,
+    );
+    socket.write(payload);
+
+    return promise;
+  }
+  const socket = net.connect({ port: port, host: "127.0.0.1" }, async () => {
+    const timer = setTimeout(() => {
+      console.error("timeout");
+      process.exit(1);
+    }, 30_000).unref();
+    await sendRequest(socket);
+    await sendRequest(socket);
+    await sendRequest(socket);
+    console.log("request sent");
+    clearTimeout(timer);
+    process.exit(0);
+  });
+  socket.on("error", err => {
+    console.error(err);
+    process.exit(1);
+  });
+}
+
+const app = next({ dev: true, dir: import.meta.dirname, quiet: true });
+const handle = app.getRequestHandler();
+
+app.prepare().then(() => {
+  const server = http
+    .createServer((req, res) => {
+      const parsedUrl = parse(req.url, true);
+      handle(req, res, parsedUrl);
+    })
+    .listen(0, "127.0.0.1", () => {
+      console.log("server listening", server.address().port);
+      test(server.address().port);
+    });
+});

test/js/third_party/next-auth/fixture/public/globe.svg

@@ -0,0 +1,3 @@
+import { handlers } from "@/auth";
+
+export const { GET, POST } = handlers;

test/js/third_party/next-auth/fixture/public/next.svg

@@ -0,0 +1,10 @@
+import { NextRequest } from 'next/server';
+
+export async function POST(request: NextRequest) {
+  try {
+    const body = await request.json();
+    return Response.json(body);
+  } catch (error) {
+    return Response.json({ error: 'Invalid JSON' }, { status: 400 });
+  }
+}

test/js/third_party/next-auth/fixture/public/vercel.svg

@@ -0,0 +1,75 @@
+'use client';
+
+import { useState } from 'react';
+import Link from 'next/link';
+
+export default function EchoPage() {
+  const [input, setInput] = useState('');
+  const [response, setResponse] = useState<any>(null);
+  const [loading, setLoading] = useState(false);
+
+  const handleSubmit = async (e: React.FormEvent) => {
+    e.preventDefault();
+    setLoading(true);
+    
+    try {
+      const res = await fetch('/api/echo', {
+        method: 'POST',
+        headers: {
+          'Content-Type': 'application/json',
+        },
+        body: JSON.stringify({ message: input }),
+      });
+      
+      const data = await res.json();
+      setResponse(data);
+    } catch (error) {
+      setResponse({ error: 'Failed to fetch' });
+    } finally {
+      setLoading(false);
+    }
+  };
+
+  return (
+    <div className="flex min-h-screen flex-col items-center justify-center p-8">
+      <main className="w-full max-w-md">
+        <h1 className="text-2xl font-bold mb-6">Echo API Demo</h1>
+        
+        <form onSubmit={handleSubmit} className="mb-6">
+          <div className="flex flex-col gap-4">
+            <input
+              type="text"
+              value={input}
+              onChange={(e) => setInput(e.target.value)}
+              placeholder="Enter a message"
+              className="p-3 border rounded-md"
+            />
+            <button 
+              type="submit" 
+              disabled={loading}
+              className="p-3 bg-indigo-600 text-white rounded-md hover:bg-indigo-700 disabled:opacity-50"
+            >
+              {loading ? 'Sending...' : 'Send'}
+            </button>
+          </div>
+        </form>
+
+        {response && (
+          <div className="w-full p-4 border rounded-md mb-6">
+            <h2 className="text-lg font-bold mb-2">Response:</h2>
+            <pre className="bg-gray-100 p-3 rounded overflow-auto">
+              {JSON.stringify(response, null, 2)}
+            </pre>
+          </div>
+        )}
+
+        <Link
+          href="/"
+          className="text-indigo-600 hover:underline"
+        >
+          ← Back to home
+        </Link>
+      </main>
+    </div>
+  );
+}

test/js/third_party/next-auth/fixture/public/window.svg

@@ -0,0 +1,26 @@
+@import "tailwindcss";
+
+:root {
+  --background: #ffffff;
+  --foreground: #171717;
+}
+
+@theme inline {
+  --color-background: var(--background);
+  --color-foreground: var(--foreground);
+  --font-sans: var(--font-geist-sans);
+  --font-mono: var(--font-geist-mono);
+}
+
+@media (prefers-color-scheme: dark) {
+  :root {
+    --background: #0a0a0a;
+    --foreground: #ededed;
+  }
+}
+
+body {
+  background: var(--background);
+  color: var(--foreground);
+  font-family: Arial, Helvetica, sans-serif;
+}

test/js/third_party/next-auth/fixture/server.js

@@ -0,0 +1,34 @@
+import type { Metadata } from "next";
+import { Geist, Geist_Mono } from "next/font/google";
+import "./globals.css";
+
+const geistSans = Geist({
+  variable: "--font-geist-sans",
+  subsets: ["latin"],
+});
+
+const geistMono = Geist_Mono({
+  variable: "--font-geist-mono",
+  subsets: ["latin"],
+});
+
+export const metadata: Metadata = {
+  title: "Create Next App",
+  description: "Generated by create next app",
+};
+
+export default function RootLayout({
+  children,
+}: Readonly<{
+  children: React.ReactNode;
+}>) {
+  return (
+    <html lang="en">
+      <body
+        className={`${geistSans.variable} ${geistMono.variable} antialiased`}
+      >
+        {children}
+      </body>
+    </html>
+  );
+}

test/js/third_party/next-auth/fixture/src/app/api/auth/[...nextauth]/route.ts

@@ -0,0 +1,9 @@
+import { auth } from "@/auth";
+
+export default async function Home() {
+  const session = await auth();
+  
+  return (
+    <div>Hello</div>
+  );
+}

test/js/third_party/next-auth/fixture/src/app/api/echo/route.ts

@@ -0,0 +1,20 @@
+import { auth, signOut } from "@/auth";
+
+export default async function ProtectedPage() {
+  const session = await auth();
+  
+  return (
+    <div >
+    <form action={async () => {
+      "use server";
+      await signOut({ redirectTo: "/" });
+    }}>
+      <button
+        type="submit"
+      >
+        Sign out
+      </button>
+    </form>
+  </div>
+  );
+}