fix(plugin-search): delete does not also delete the search doc #12148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanRibbens
changed the title
r1tsuu
approved these changes
Apr 18, 2025
|
Looks great! Yeah, this was the solution I ended up on as well - albeit took me much longer to realize what was actually happening with the transaction/doc not being surfaced haha. There is an added little improvement here in omitting an extra find and just using a I was directing users to this solution in the meantime. Super happy to see it finally getting resolved here! Thanks for your work. |
|
🚀 This is included in version v3.36.0 |
kendelljoseph
pushed a commit
that referenced
this pull request
May 15, 2025
The plugin-search collection uses an `afterDelete` hook to remove search records from the database. Since a deleted document in postgres causes cascade updates for the foreign key, the query for the document by relationship was not returning the record to be deleted. The solution was to change the delete hook to `beforeDelete` for the search enabled collections. This way we purge records before the main document so the search document query can find and delete the record as expected. An alternative solution in #9623 would remove the `req` so the delete query could still find the document, however, this just works outside of transactions which isn't desirable. fixes #9443
kendelljoseph
pushed a commit
that referenced
this pull request
May 19, 2025
The plugin-search collection uses an `afterDelete` hook to remove search records from the database. Since a deleted document in postgres causes cascade updates for the foreign key, the query for the document by relationship was not returning the record to be deleted. The solution was to change the delete hook to `beforeDelete` for the search enabled collections. This way we purge records before the main document so the search document query can find and delete the record as expected. An alternative solution in #9623 would remove the `req` so the delete query could still find the document, however, this just works outside of transactions which isn't desirable. fixes #9443
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plugin-search collection uses an
afterDeletehook to remove search records from the database. Since a deleted document in postgres causes cascade updates for the foreign key, the query for the document by relationship was not returning the record to be deleted.The solution was to change the delete hook to
beforeDeletefor the search enabled collections. This way we purge records before the main document so the search document query can find and delete the record as expected.An alternative solution in #9623 would remove the
reqso the delete query could still find the document, however, this just works outside of transactions which isn't desirable.fixes #9443