feat(ui): make select and relationship field placeholder configurable #12253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for configurable placeholder text for select and relationship fields in both the admin interface and filter options. Key changes include:
- Introducing a new admin property (admin.placeholder) in select and relationship field configurations.
- Updating UI components to propagate and render the custom placeholder.
- Adding end-to-end tests to verify placeholder functionality in list and edit views.
Reviewed Changes
Copilot reviewed 13 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/admin/slugs.ts | Added new slug for placeholder collection |
| test/admin/e2e/list-view/e2e.spec.ts | Added new tests to check placeholder functionality |
| test/admin/config.ts | Config updated to include the new Placeholder collection |
| test/admin/collections/Placeholder.ts | New collection for testing placeholder fields |
| packages/ui/src/fields/Select/index.ts | Propagates placeholder from admin config into Select field |
| packages/ui/src/fields/Select/Input.ts | Updates to support placeholder in select input component, includes a debugging log |
| packages/ui/src/fields/Relationship/index.ts | Propagates placeholder into the Relationship field component |
| packages/ui/src/elements/WhereBuilder/Condition/* | Updated types and usage to include placeholder for filters |
| packages/ui/src/elements/ReactSelect/* | Updated to support placeholder translation |
| packages/payload/src/fields/config/types.ts | Updated field configuration types to include a placeholder prop |
Files not reviewed (2)
- docs/fields/relationship.mdx: Language not supported
- docs/fields/select.mdx: Language not supported
Co-authored-by: Copilot <[email protected]>
This reverts commit 2eb9b8f.
DanRibbens
approved these changes
May 1, 2025
|
🚀 This is included in version v3.37.0 |
kendelljoseph
pushed a commit
that referenced
this pull request
May 15, 2025
…#12253) ### What? Allows to overwrite the default placeholder text of select and relationship fields. ### Why? The default placeholder text is generic. In some scenarios a custom placeholder can guide the user better. ### How? Adds a new property `admin.placeholder` to relationship and select field which allows to define an alternative text or translation function for the placeholder. The placeholder is used in the form fields as well as in the filter options.   --------- Co-authored-by: Dan Ribbens <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Dan Ribbens <[email protected]>
kendelljoseph
pushed a commit
that referenced
this pull request
May 19, 2025
…#12253) ### What? Allows to overwrite the default placeholder text of select and relationship fields. ### Why? The default placeholder text is generic. In some scenarios a custom placeholder can guide the user better. ### How? Adds a new property `admin.placeholder` to relationship and select field which allows to define an alternative text or translation function for the placeholder. The placeholder is used in the form fields as well as in the filter options.   --------- Co-authored-by: Dan Ribbens <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Dan Ribbens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Allows to overwrite the default placeholder text of select and relationship fields.
Why?
The default placeholder text is generic. In some scenarios a custom placeholder can guide the user better.
How?
Adds a new property
admin.placeholderto relationship and select field which allows to define an alternative text or translation function for the placeholder. The placeholder is used in the form fields as well as in the filter options.