-
Notifications
You must be signed in to change notification settings - Fork 33
Refactor library - New Penpot Export Format #254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Cenadros
wants to merge
17
commits into
main
Choose a base branch
from
feature/refactor-library
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
May 29, 2025
feat: enhance ExporterProgress component to display current export item fix: modify useFigma hook to capture and display progress messages during export
…transformGroupNodeLike functions to SceneNode for consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several updates to the codebase, focusing on improving the handling of shape transformations, simplifying path translation logic, and enhancing stroke and effect translations. Additionally, it includes dependency updates and cleanup of unused imports. Below is a categorized summary of the most important changes:
Fill Image and Stroke Image Enhancements
Shape Transformation Enhancements:
rx
andry
properties to corner radius transformations for better compatibility with Penpot's shape representation. (plugin-src/transformers/partials/transformCornerRadius.ts
) [1] [2]transformRotationAndPosition
to acceptSceneNode
instead ofLayoutMixin
, aligning the function with broader node compatibility. (plugin-src/transformers/partials/transformRotationAndPosition.ts
)transformGroupNodeLike
function to useSceneNode
directly, simplifying node handling. (plugin-src/transformers/transformGroupNode.ts
)Path Translation Simplifications:
Segment
type with directCommand
usage in path translation logic, and introduced functions to generate SVG path strings (translateCommandsToPathString
). (plugin-src/translators/vectors/translateNonRotatedCommands.ts
,plugin-src/translators/vectors/translateRotatedCommands.ts
) [1] [2] [3]Segment
imports across files to clean up dependencies. (plugin-src/transformers/transformLineNode.ts
,plugin-src/transformers/transformPathNode.ts
,plugin-src/utils/applyRotation.ts
) [1] [2] [3]Stroke and Effect Translation Improvements:
#000000
) and supportingStrokeImage
for image-based strokes. (plugin-src/translators/translateStrokes.ts
) [1] [2]id
property to shadow effect translations for better identification. (plugin-src/translators/translateShadowEffects.ts
)BlurEffectBase
type in blur effect translation for stricter type safety. (plugin-src/translators/translateBlurEffects.ts
)Dependency Updates:
@penpot/library
dependency topackage.json
for Penpot integration support. (package.json
)Other Changes:
syncAttributes
by removing unnecessary colons in attribute group names. (plugin-src/translators/translateTouched.ts
)