Skip to content

Implement color correction #4315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mvaligursky opened this issue Jun 9, 2022 · 2 comments · May be fixed by #7720
Open

Implement color correction #4315

mvaligursky opened this issue Jun 9, 2022 · 2 comments · May be fixed by #7720
Assignees
@mvaligursky
Labels
area: graphics Graphics related issue feature

Comments

@mvaligursky
Copy link
Contributor

Details to be figured out, but based on something equivalent to 3D LUT texture.
This could be done either inlined in the shaders, or as a post-processing.
@mvaligursky mvaligursky added feature area: graphics Graphics related issue labels Jun 9, 2022
@Maksims
Copy link
Collaborator

Maksims commented Jun 10, 2022

Inlined in a shader would be faster on mobile, as any post-process on mobile leads to an extra few ms overheads due to mobile GPUs.
Also inline will allow to control it per material and per mesh, just like with tone mapping and gamma correction currently.

@mvaligursky
Copy link
Contributor Author

perhaps we implement support for .CUBE format LUTs, which is the most common color grading format, used by Video Editing Software. Easy to parse. Represents a cube texture, easy to parse. Example attached.

Cine-4-debarup.zip

@mvaligursky mvaligursky linked a pull request May 27, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added color correction using LUT texture to CameraFrame postprocessing playcanvas/engine
3 participants
@Maksims @mvaligursky @GSterbrant