Skip to content

BlockObjectToStateSerializer: Allow serializers to return an ID string directly instead of a BlockStateWriter instance #6675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dktapps opened this issue Apr 20, 2025 · 0 comments
Open

BlockObjectToStateSerializer: Allow serializers to return an ID string directly instead of a BlockStateWriter instance #6675

dktapps opened this issue Apr 20, 2025 · 0 comments
Labels
Category: API Related to the plugin API Category: Core Related to internal functionality Performance Type: Enhancement Contributes features or other improvements to PocketMine-MP

Comments

@dktapps
Copy link
Member

dktapps commented Apr 20, 2025

Link to crashdump

https://crash.pmmp.io/view/12462321

Additional comments (optional)

Most common blocks don't need to store any properties. In these cases we can avoid redundant object allocations by allowing the serializer handlers to just return IDs directly.

This crashdump was likely caused by a mistake, but the idea is a good one.
@dktapps dktapps added Category: API Related to the plugin API Category: Core Related to internal functionality Performance Type: Enhancement Contributes features or other improvements to PocketMine-MP labels Apr 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category: API Related to the plugin API Category: Core Related to internal functionality Performance Type: Enhancement Contributes features or other improvements to PocketMine-MP
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dktapps