Skip to content

New release available "@primer/[email protected]" #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
3 tasks
github-actions bot opened this issue May 22, 2025 · 2 comments
Open
3 tasks

New release available "@primer/[email protected]" #12

github-actions bot opened this issue May 22, 2025 · 2 comments
Labels

Comments

@github-actions
Copy link

A new release is available: https://github.com/primer/brand/releases/tag/%40primer/react-brand%400.54.1.

Changelog

See documentation for this release

Patch Changes

  • #1025 667d820 Thanks @joshfarrant! - Removed aria-describedby from AnchorNav.Link component.

  • #1015 1afeeae Thanks @danielguillan! - Fixed an issue in ActionMenu where anchor links in split-button mode were only clickable on the text. Now, the clickable area covers the full width and height of the item.

  • #1024 97b7a97 Thanks @joshfarrant! - Improved accessibility of SubNav component when no active link — denoted by aria-current="page" — is present.

    • Hide last separator (on large viewports only) when there is no active link
    • Set a fallback accessible label on the overlay toggle when there is no active link
  • #1020 584280e Thanks @joshfarrant! - ActionMenu bugfixes:

    • Fixed a bug in ActionMenu.Item where provided onClick and onKeyDown handlers wouldn't be called.
    • Fixed a bug which allowed Tab to cycle through the list of ActionMenu.Item elements which resulted in unpredictable focus behaviour. The intended way to navigate through the list is by using the arrow keys.
  • #1012 ce945a2 Thanks @joshfarrant! - Removed the Checkbox and Radio components' built-in <label> as it was only used for styling and would result in inputs having two associated labels when used inside a FormControl.

  • #1017 dd93551 Thanks @joshfarrant! - Increased the touch target size of SubNav.SubMenu toggle button

❗ Dotcom integration checklist

Note

GitHub Staff only

Please ensure these items are checked before merging.

  • Performed successful integration test with github/github
  • Manually verify regressions on following pages against production:
  • /features/copilot
  • /enterprise
  • /enterprise/advanced-security
  • /articles/security
  • /articles/security/what-is-security-testing
  • /features/preview
  • /features/copilot/getting-started and /features/copilot
  • /solutions/devops
  • /education
  • /mobile
  • /contact-sales
  • /about/diversity
Copy link
Author

Smoke test results (2025/05/22 - 16:00)

  • SubNav.SubMenu toggle button target size 🟢

    • Works as expected — tested in dotcom
  • Fix ActionMenu split-button anchor size 🟢

    • Works as expected — tested in Storybook and CodeSandbox
  • onClick and onKeyDown get called in split ActionMenu 🟢

    • Works as expected — tested in Storybook and CodeSandbox
  • SubNav a11y where no active link is present 🔴

    • Regression introduced: the separator is removed from all viewport sizes when no current-page is set, but it should only be removed on small viewports.

    image

  • Removed aria-describedby` from AnchorNav.Link 🟢

    • Works as expected — tested in dotcom

Release testing status: Paused 🔴 - Requires fix for SubNav separator

Copy link
Author

Smoke test results (2025/05/22 - 17:25)

  • SubNav.SubMenu toggle button target size 🟢
    • Works as expected — tested in dotcom
  • Fix ActionMenu split-button anchor size 🟢
    • Works as expected — tested in Storybook and CodeSandbox
  • onClick and onKeyDown get called in split ActionMenu 🟢
    • Works as expected — tested in Storybook and CodeSandbox
  • SubNav a11y where no active link is present 🟢
    • Regression fixed in #1027 and verified to work in dotcom
  • Removed aria-describedby` from AnchorNav.Link 🟢
    • Works as expected — tested in dotcom

Release testing status: Ready to release 🟢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

0 participants