Skip to content

Support custom max-width values in Dialog for cases where finer control is needed for a balanced layout. #5684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
maximedegreve opened this issue Feb 10, 2025 · 1 comment
Open

Support custom max-width values in Dialog for cases where finer control is needed for a balanced layout. #5684

maximedegreve opened this issue Feb 10, 2025 · 1 comment
Assignees
@langermank
Labels
component: Dialog react

Comments

@maximedegreve
Copy link
Contributor

maximedegreve commented Feb 10, 2025 •
edited
Loading

Example

In the below example the default 480px and 320px either too large or too narrow.

Feedback dialog UI shown at a 480px width, 400px width and 320px width

Links
@primer primer deleted a comment from github-actions bot Feb 10, 2025
@sunnyi101 sunnyi101 self-assigned this Feb 18, 2025
@tallys
Copy link

tallys commented Feb 24, 2025

@langermank will follow up with this issue to move it into github/primer

@langermank langermank assigned langermank and unassigned sunnyi101 Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@langermank langermank

Labels
component: Dialog react
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@maximedegreve @tallys @langermank @sunnyi101