Skip to content

fix(crawl): replace WaitLoad/Idle to WaitStable to ensure all requests have been made #1217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 31, 2025
Merged

fix(crawl): replace WaitLoad/Idle to WaitStable to ensure all requests have been made #1217

merged 6 commits into from
Mar 31, 2025

Conversation

alban-stourbe-wmx
Copy link
Contributor

@alban-stourbe-wmx alban-stourbe-wmx commented Mar 19, 2025 •
edited by dogancanbakir
Loading

Closes #1218

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Mar 19, 2025 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@alban-stourbe-wmx alban-stourbe-wmx changed the title Feature/new way to wait page fix(crawl): replace WaitLoad/Idle to WaitStable to ensure all request… a9ccdf9 …s have been made Mar 19, 2025
@alban-stourbe-wmx alban-stourbe-wmx changed the title fix(crawl): replace WaitLoad/Idle to WaitStable to ensure all request… a9ccdf9 …s have been made fix(crawl): replace WaitLoad/Idle to WaitStable to ensure all requests have been made Mar 19, 2025
@alban-stourbe-wmx alban-stourbe-wmx mentioned this pull request Mar 19, 2025
Open
@GeorginaReeder
Copy link

Thanks for your contribution @alban-stourbe-wmx ! :)

@ehsandeep ehsandeep linked an issue Mar 24, 2025 that may be closed by this pull request
Hybrid : Page Completes Processing Without Waiting for All Requests to Finish #1218
Open
Mzack9999
Mzack9999 approved these changes Mar 31, 2025
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Very nice addition, eventually later on we can try to reduce the minimum wait time for WaitStable if 1s appears to introduce too much delay

@Mzack9999 Mzack9999 merged commit 24c7131 into projectdiscovery:dev Mar 31, 2025
14 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Apr 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mzack9999 Mzack9999 Mzack9999 approved these changes

@dogancanbakir dogancanbakir dogancanbakir approved these changes

@ehsandeep ehsandeep Awaiting requested review from ehsandeep

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hybrid : Page Completes Processing Without Waiting for All Requests to Finish
6 participants
@alban-stourbe-wmx @GeorginaReeder @Mzack9999 @dogancanbakir @ehsandeep @LukasForst