Skip to content

remove schema in aggs #1888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 22, 2023
Merged

remove schema in aggs #1888

merged 2 commits into from
Feb 22, 2023

Conversation

PSeitz
Copy link
Collaborator

@PSeitz PSeitz commented Feb 21, 2023

  • switch to ColumnType, move tests
  • remove Schema dependency in agg

remove schema dependency in preparation to support aggregation on JSON fields

@codecov-commenter
Copy link

Codecov Report

Merging #1888 (0248928) into main (e2aa5af) will decrease coverage by 0.03%.
The diff coverage is 99.90%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1888      +/-   ##
==========================================
- Coverage   94.64%   94.62%   -0.03%     
==========================================
  Files         301      302       +1     
  Lines       54924    54918       -6     
==========================================
- Hits        51985    51967      -18     
- Misses       2939     2951      +12     
Impacted Files Coverage Δ
src/aggregation/mod.rs 93.68% <90.90%> (-4.59%) ⬇️
columnar/src/columnar/column_type.rs 81.33% <100.00%> (ø)
src/aggregation/agg_req_with_accessor.rs 98.05% <100.00%> (-0.16%) ⬇️
src/aggregation/agg_result.rs 73.77% <100.00%> (-1.23%) ⬇️
src/aggregation/agg_tests.rs 100.00% <100.00%> (ø)
src/aggregation/bucket/histogram/histogram.rs 99.55% <100.00%> (-0.01%) ⬇️
src/aggregation/bucket/range.rs 97.49% <100.00%> (+0.02%) ⬆️
src/aggregation/collector.rs 96.62% <100.00%> (-0.04%) ⬇️
src/aggregation/intermediate_agg_result.rs 97.69% <100.00%> (+<0.01%) ⬆️
src/aggregation/metric/mod.rs 94.23% <100.00%> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@PSeitz PSeitz merged commit c7278b3 into main Feb 22, 2023
@PSeitz PSeitz deleted the json_agg branch February 22, 2023 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants