Updates the kind in some of the unit tests

Author: mik-dass

pkg/storage/kubernetes.go

@@ -32,8 +32,7 @@ type kubernetesClient struct {
 func (k kubernetesClient) Create(storage Storage) error {
 
 	if k.componentName == "" || k.appName == "" {
-		// required for generating the labels
-		return fmt.Errorf("the component name, the app name or both are empty")
+		return fmt.Errorf("the component name and the app name should be provided")
 	}
 
 	pvcName, err := generatePVCName(storage.Name, k.componentName, k.appName)

pkg/storage/utils.go

@@ -58,7 +58,7 @@ func GetMachineReadableFormat(storageName, storageSize, storagePath string) Stor
 // storagePath indicates the path to which the storage is mounted to, "" if not mounted
 func GetMachineFormatWithContainer(storageName, storageSize, storagePath string, container string) Storage {
 	storage := Storage{
-		TypeMeta:   metav1.TypeMeta{Kind: "storage", APIVersion: apiVersion},
+		TypeMeta:   metav1.TypeMeta{Kind: "Storage", APIVersion: apiVersion},
 		ObjectMeta: metav1.ObjectMeta{Name: storageName},
 		Spec: StorageSpec{
 			Size: storageSize,
@@ -104,7 +104,7 @@ func ConvertListLocalToMachine(storageListConfig []localConfigProvider.LocalStor
 func MachineReadableSuccessOutput(storageName string, message string) {
 	machineOutput := machineoutput.GenericSuccess{
 		TypeMeta: metav1.TypeMeta{
-			Kind:       "storage",
+			Kind:       "Storage",
 			APIVersion: apiVersion,
 		},
 		ObjectMeta: metav1.ObjectMeta{

pkg/storage/utils_test.go

@@ -9,38 +9,38 @@ import (
 
 func TestGetMachineReadableFormat(t *testing.T) {
 	tests := []struct {
-		name         string
-		storageName  string
-		storageSize  string
-		mountedPath  string
-		want         Storage
+		name        string
+		storageName string
+		storageSize string
+		mountedPath string
+		want        Storage
 	}{
 		{
-			name:         "test case 1: with a pvc, valid path and mounted status",
-			storageName:  "pvc-example",
-			storageSize:  "100Mi",
-			mountedPath:  "data",
+			name:        "test case 1: with a pvc, valid path and mounted status",
+			storageName: "pvc-example",
+			storageSize: "100Mi",
+			mountedPath: "data",
 			want: Storage{
 				ObjectMeta: metav1.ObjectMeta{
 					Name: "pvc-example",
 				},
-				TypeMeta: metav1.TypeMeta{Kind: "storage", APIVersion: "odo.dev/v1alpha1"},
+				TypeMeta: metav1.TypeMeta{Kind: "Storage", APIVersion: "odo.dev/v1alpha1"},
 				Spec: StorageSpec{
 					Size: "100Mi",
 					Path: "data",
 				},
 			},
 		},
 		{
-			name:         "test case 2: with a pvc, empty path and unmounted status",
-			storageName:  "pvc-example",
-			storageSize:  "500Mi",
-			mountedPath:  "",
+			name:        "test case 2: with a pvc, empty path and unmounted status",
+			storageName: "pvc-example",
+			storageSize: "500Mi",
+			mountedPath: "",
 			want: Storage{
 				ObjectMeta: metav1.ObjectMeta{
 					Name: "pvc-example",
 				},
-				TypeMeta: metav1.TypeMeta{Kind: "storage", APIVersion: "odo.dev/v1alpha1"},
+				TypeMeta: metav1.TypeMeta{Kind: "Storage", APIVersion: "odo.dev/v1alpha1"},
 				Spec: StorageSpec{
 					Size: "500Mi",
 					Path: "",
@@ -73,7 +73,7 @@ func TestGetMachineReadableFormatForList(t *testing.T) {
 						Name: "example-pvc-1",
 					},
 					TypeMeta: metav1.TypeMeta{
-						Kind:       "List",
+						Kind:       "Storage",
 						APIVersion: "odo.dev/v1alpha1",
 					},
 					Spec: StorageSpec{
@@ -94,7 +94,7 @@ func TestGetMachineReadableFormatForList(t *testing.T) {
 							Name: "example-pvc-1",
 						},
 						TypeMeta: metav1.TypeMeta{
-							Kind:       "List",
+							Kind:       "Storage",
 							APIVersion: "odo.dev/v1alpha1",
 						},
 						Spec: StorageSpec{
@@ -113,7 +113,7 @@ func TestGetMachineReadableFormatForList(t *testing.T) {
 						Name: "example-pvc-0",
 					},
 					TypeMeta: metav1.TypeMeta{
-						Kind:       "List",
+						Kind:       "Storage",
 						APIVersion: "odo.dev/v1alpha1",
 					},
 					Spec: StorageSpec{
@@ -126,7 +126,7 @@ func TestGetMachineReadableFormatForList(t *testing.T) {
 						Name: "example-pvc-1",
 					},
 					TypeMeta: metav1.TypeMeta{
-						Kind:       "List",
+						Kind:       "Storage",
 						APIVersion: "odo.dev/v1alpha1",
 					},
 					Spec: StorageSpec{
@@ -147,7 +147,7 @@ func TestGetMachineReadableFormatForList(t *testing.T) {
 							Name: "example-pvc-0",
 						},
 						TypeMeta: metav1.TypeMeta{
-							Kind:       "List",
+							Kind:       "Storage",
 							APIVersion: "odo.dev/v1alpha1",
 						},
 						Spec: StorageSpec{
@@ -160,7 +160,7 @@ func TestGetMachineReadableFormatForList(t *testing.T) {
 							Name: "example-pvc-1",
 						},
 						TypeMeta: metav1.TypeMeta{
-							Kind:       "List",
+							Kind:       "Storage",
 							APIVersion: "odo.dev/v1alpha1",
 						},
 						Spec: StorageSpec{