Skip to content

Commit e9c739b

Browse files
committed
Update doc
1 parent 0cf37da commit e9c739b

File tree

1 file changed

+5
-23
lines changed

1 file changed

+5
-23
lines changed

docs/proposals/commands-semantic.md

Lines changed: 5 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ Components:
88

99
| Command | PreStart | PostStart | PreStop | PostStop |
1010
|-----------------------------|----------|-----------|---------|-----------|
11-
| exec on container | | Y(1) | Y(1) | |
11+
| exec on container | | Y | Y | |
1212
| exec on cluster resource | N/A | N/A | N/A | N/A |
1313
| exec on volume | N/A | N/A | N/A | N/A |
1414
| exec on image | N/A | N/A | N/A | N/A |
@@ -24,15 +24,15 @@ Components:
2424

2525
| Command | Build | Run/Debug | Deploy |
2626
|-----------------------------|-------|-----------|--------|
27-
| exec on container | Y(1) | Y(2) | Y(3) |
27+
| exec on container | Y | Y | Y |
2828
| exec on cluster resource | N/A | N/A | N/A |
2929
| exec on volume | N/A | N/A | N/A |
3030
| exec on image | N/A | N/A | N/A |
3131
|   | | | |
3232
| apply on container | ? | ? | ? |
33-
| apply on cluster resource | 0 | Y(2) | Y(3) |
33+
| apply on cluster resource | 0 | Y | Y |
3434
| apply on volume | ? | ? | ? |
35-
| apply on image | 0 | Y(2) | Y(3) |
35+
| apply on image | 0 | Y | Y |
3636
|   | | | |
3737
| composite serial | | | |
3838
| composite parallel | | | |
@@ -41,24 +41,6 @@ Components:
4141
Legend:
4242

4343
- 0: Supported by handler but not implemented
44-
- Y: Implemented
44+
- Y: Implemented by pkg/component.NewRunHandler
4545
- N/A: Not applicable (by spec)
4646
- ?: Spec is not clear
47-
48-
- (1) Implemented by pkg/component.NewExecHandler
49-
- ApplyImage -> nil
50-
- ApplyKubernetes -> nil
51-
- ApplyOpenShift -> nil
52-
- Execute -> (specific, calling execClient.ExecuteCommand on existing component)
53-
54-
- (2) Implemented by pkg/dev/kubedev.runHandler / pkg.dev/podmandev.commandHandler
55-
- ApplyImage -> image.BuildPushSpecificImage / image.BuildPushSpecificImage
56-
- ApplyKubernetes -> component.ApplyKubernetes / nil (not possible)
57-
- ApplyOpenShift -> component.ApplyKubernetes / nil (not possible)
58-
- Execute -> component.ExecuteRunCommand / component.ExecuteRunCommand
59-
60-
- (3) Implemented by pkg/deploy.deployHandler
61-
- ApplyImage -> image.BuildPushSpecificImage
62-
- ApplyKubernetes -> component.ApplyKubernetes
63-
- ApplyOpenShift -> component.ApplyKubernetes
64-
- Execute -> (specific, creating a job)

0 commit comments

Comments
 (0)