Note the version and PR of removed features when using it #141642
+92
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xizheyin <[email protected]>
rustbot
added
S-waiting-on-review
xizheyin
changed the title
This comment has been minimized.
This comment has been minimized.
mejrs
reviewed
May 27, 2025
|
r? compiler (bandwidth) |
jyn514
approved these changes
May 27, 2025
|
I tried So, I use helper macros to parse |
This comment has been minimized.
This comment has been minimized.
|
gotcha - can you write out the match explicitly instead of using separately i will open an issue to make |
chenyukang
reviewed
May 27, 2025
compiler/rustc_expand/src/config.rs
Outdated
| sess.dcx().emit_err(FeatureRemoved { | ||
| span: mi.span(), | ||
| reason: f.reason.map(|reason| FeatureRemovedReason { reason }), | ||
| span, |
There was a problem hiding this comment.
nit: seems the shorthand style here has more lines of code.
There was a problem hiding this comment.
Thanks for the reminder, indeed.
xizheyin
commented
May 27, 2025
Comment on lines
+15
to
+21
| macro_rules! opt_nonzero_u32 { | ||
| () => { | ||
| None | ||
| }; | ||
| ($val:expr) => { | ||
| Some(NonZeroU32::new($val).unwrap()) | ||
| }; |
There was a problem hiding this comment.
I used an auxiliary macro to get around this to make sure the git blame doesn't get broken.
jyn514
reviewed
May 27, 2025
Signed-off-by: xizheyin <[email protected]>
jyn514
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially Fixes #141619
I added the diagnostic information. Since all the current version information is present, it prints the version information anyway, as shown in tests/ui. And PR will not print if it is None, we can gradually add the PR links.
Split into two commits for easier review.
r? compiler
cc @jyn514 Since you're on vocation in the review list, I can't r? you.