Skip to content

Commit 47cd243

Browse files
FaramosCZphracek
authored andcommitted
[bugfix] The version must be set in a separate stage, so it can be re-used in the other calls
otherwise it's not available when the rest of the ENV block is processed and the ENV values relying on this variable are malformed.
1 parent 04a7438 commit 47cd243

7 files changed

+28
-14
lines changed

10.11/Dockerfile.c10s

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,10 @@ FROM quay.io/sclorg/s2i-core-c10s:c10s
1010
# * $MYSQL_DATABASE - Name of the database to create
1111
# * $MYSQL_ROOT_PASSWORD (Optional) - Password for the 'root' MySQL account
1212

13-
ENV MYSQL_VERSION=10.11 \
14-
MYSQL_SHORT_VERSION=${MYSQL_VERSION//./} \
13+
# Standalone ENV call so this value can be re-used in the other ENVs
14+
ENV MYSQL_VERSION=10.11
15+
16+
ENV MYSQL_SHORT_VERSION=${MYSQL_VERSION//./} \
1517
VERSION=${MYSQL_VERSION} \
1618
APP_DATA=/opt/app-root/src \
1719
HOME=/var/lib/mysql \

10.11/Dockerfile.c9s

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,10 @@ FROM quay.io/sclorg/s2i-core-c9s:c9s
1010
# * $MYSQL_DATABASE - Name of the database to create
1111
# * $MYSQL_ROOT_PASSWORD (Optional) - Password for the 'root' MySQL account
1212

13-
ENV MYSQL_VERSION=10.11 \
14-
MYSQL_SHORT_VERSION=${MYSQL_VERSION//./} \
13+
# Standalone ENV call so this value can be re-used in the other ENVs
14+
ENV MYSQL_VERSION=10.11
15+
16+
ENV MYSQL_SHORT_VERSION=${MYSQL_VERSION//./} \
1517
VERSION=${MYSQL_VERSION} \
1618
APP_DATA=/opt/app-root/src \
1719
HOME=/var/lib/mysql \

10.11/Dockerfile.fedora

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,10 @@ FROM quay.io/fedora/s2i-core:42
1010
# * $MYSQL_DATABASE - Name of the database to create
1111
# * $MYSQL_ROOT_PASSWORD (Optional) - Password for the 'root' MySQL account
1212

13-
ENV MYSQL_VERSION=10.11 \
14-
MYSQL_SHORT_VERSION=${MYSQL_VERSION//./} \
13+
# Standalone ENV call so this value can be re-used in the other ENVs
14+
ENV MYSQL_VERSION=10.11
15+
16+
ENV MYSQL_SHORT_VERSION=${MYSQL_VERSION//./} \
1517
VERSION=${MYSQL_VERSION} \
1618
APP_DATA=/opt/app-root/src \
1719
HOME=/var/lib/mysql \

10.11/Dockerfile.rhel10

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,10 @@ FROM ubi10/s2i-core
1010
# * $MYSQL_DATABASE - Name of the database to create
1111
# * $MYSQL_ROOT_PASSWORD (Optional) - Password for the 'root' MySQL account
1212

13-
ENV MYSQL_VERSION=10.11 \
14-
MYSQL_SHORT_VERSION=${MYSQL_VERSION//./} \
13+
# Standalone ENV call so this value can be re-used in the other ENVs
14+
ENV MYSQL_VERSION=10.11
15+
16+
ENV MYSQL_SHORT_VERSION=${MYSQL_VERSION//./} \
1517
VERSION=${MYSQL_VERSION} \
1618
APP_DATA=/opt/app-root/src \
1719
HOME=/var/lib/mysql \

10.11/Dockerfile.rhel9

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,10 @@ FROM ubi9/s2i-core
1010
# * $MYSQL_DATABASE - Name of the database to create
1111
# * $MYSQL_ROOT_PASSWORD (Optional) - Password for the 'root' MySQL account
1212

13-
ENV MYSQL_VERSION=10.11 \
14-
MYSQL_SHORT_VERSION=${MYSQL_VERSION//./} \
13+
# Standalone ENV call so this value can be re-used in the other ENVs
14+
ENV MYSQL_VERSION=10.11
15+
16+
ENV MYSQL_SHORT_VERSION=${MYSQL_VERSION//./} \
1517
VERSION=${MYSQL_VERSION} \
1618
APP_DATA=/opt/app-root/src \
1719
HOME=/var/lib/mysql \

10.5/Dockerfile.c9s

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,10 @@ FROM quay.io/sclorg/s2i-core-c9s:c9s
1010
# * $MYSQL_DATABASE - Name of the database to create
1111
# * $MYSQL_ROOT_PASSWORD (Optional) - Password for the 'root' MySQL account
1212

13-
ENV MYSQL_VERSION=10.5 \
14-
MYSQL_SHORT_VERSION=${MYSQL_VERSION//./} \
13+
# Standalone ENV call so this value can be re-used in the other ENVs
14+
ENV MYSQL_VERSION=10.5
15+
16+
ENV MYSQL_SHORT_VERSION=${MYSQL_VERSION//./} \
1517
VERSION=${MYSQL_VERSION} \
1618
APP_DATA=/opt/app-root/src \
1719
HOME=/var/lib/mysql \

10.5/Dockerfile.rhel9

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,10 @@ FROM ubi9/s2i-core
1010
# * $MYSQL_DATABASE - Name of the database to create
1111
# * $MYSQL_ROOT_PASSWORD (Optional) - Password for the 'root' MySQL account
1212

13-
ENV MYSQL_VERSION=10.5 \
14-
MYSQL_SHORT_VERSION=${MYSQL_VERSION//./} \
13+
# Standalone ENV call so this value can be re-used in the other ENVs
14+
ENV MYSQL_VERSION=10.5
15+
16+
ENV MYSQL_SHORT_VERSION=${MYSQL_VERSION//./} \
1517
VERSION=${MYSQL_VERSION} \
1618
APP_DATA=/opt/app-root/src \
1719
HOME=/var/lib/mysql \

0 commit comments

Comments
 (0)