Fix scraper script #8
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The `reply_broadcast` message has been removed, but a reference without any documentation is present on the website. This meant that the sample was empty, causing other problems down the line. - The new `thread_broadcast` message has an unbalanced number of curly braces in the sample JSON. Balance them before parsing.
|
Friendly ping :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Fixes #7)
The scraper script crashes with this error:
This happens because the
reply_broadcastdocs does not have a sample anymore since the message has been removed.Second problem is that the
thread_broadcastmessage has unbalanced curly braces in the sample (it's missing a closing brace for themessageobject).