add optional initalValue argument to from helper (#2429)

* add optional initalValue to `from` helper

* Create dull-bikes-reply.md

---------

Co-authored-by: Ryan Carniato <[email protected]>

Author: chris-kruining

.changeset/dull-bikes-reply.md

@@ -0,0 +1,5 @@
+---
+"solid-js": patch
+---
+
+add optional initalValue argument to `from` helper

packages/solid/src/reactive/observable.ts

@@ -84,18 +84,20 @@ export function observable<T>(input: Accessor<T>): Observable<T> {
   };
 }
 
-export function from<T>(
-  producer:
-    | ((setter: Setter<T | undefined>) => () => void)
-    | { subscribe: (fn: (v: T) => void) => (() => void) | { unsubscribe: () => void } }
-): Accessor<T | undefined> {
-  const [s, set] = createSignal<T | undefined>(undefined, { equals: false });
-  if ("subscribe" in producer) {
-    const unsub = producer.subscribe(v => set(() => v));
-    onCleanup(() => ("unsubscribe" in unsub ? unsub.unsubscribe() : unsub()));
-  } else {
-    const clean = producer(set);
-    onCleanup(clean);
-  }
-  return s;
+type Producer<T> =
+    | ((setter: Setter<T>) => () => void)
+    | { subscribe: (fn: (v: T) => void) => (() => void) | { unsubscribe: () => void } };
+
+export function from<T>(producer: Producer<T>, initalValue: T): Accessor<T>;
+export function from<T>(producer: Producer<T|undefined>): Accessor<T|undefined>;
+export function from<T>(producer: Producer<T|undefined>, initalValue: T|undefined = undefined): Accessor<T | undefined> {
+    const [s, set] = createSignal<T | undefined>(initalValue, { equals: false });
+    if ("subscribe" in producer) {
+        const unsub = producer.subscribe(v => set(() => v));
+        onCleanup(() => ("unsubscribe" in unsub ? unsub.unsubscribe() : unsub()));
+    } else {
+        const clean = producer(set);
+        onCleanup(clean);
+    }
+    return s;
 }