Skip to content

Windows integration test broken #6044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kfox1111 opened this issue May 2, 2025 · 2 comments
Open

Windows integration test broken #6044

kfox1111 opened this issue May 2, 2025 · 2 comments
Assignees
Labels
priority/backlog Issue is approved and in the backlog

Comments

@kfox1111
Copy link
Contributor

kfox1111 commented May 2, 2025

I submitted a change that is not being reflected in the tests. It looks like the integration test is using a previous build of the pr for testing newer versions of it. There is no way the newer version of the pr can generate the string that it is outputting. Seems like its maybe caching builds incorrectly.

@sorindumitru sorindumitru added the triage/in-progress Issue triage is in progress label May 6, 2025
@MarcosDY MarcosDY added priority/backlog Issue is approved and in the backlog and removed triage/in-progress Issue triage is in progress labels May 6, 2025
@sorindumitru
Copy link
Collaborator

https://github.com/spiffe/spire/actions/runs/14900201144/job/41850741600?pr=6047 shows the issue:

Cache hit for: Windows-executables-
<snip />
Cache restored from key: Windows-executables-f2c21bc899ea5627ac983fa02be7b358fdd6ea06fabec43b34d34a48d52ec901

We try to restore the exe files for spire-server and spire-agent in

key: ${{ runner.os }}-executables-${{ hashFiles('**/*.exe') }}
. We do that because we don't have them, doh, so that hashFiles(**/*.exe) produces an empty string.

If an exact match isn't found for the cache name, a partial match is returned:

key: ${{ runner.os }}-executables-${{ hashFiles('**/*.exe') }}
, which is why we aren't failing here.

I'll see how to go about fixing this.

@kfox1111
Copy link
Contributor Author

kfox1111 commented May 8, 2025

Doh. Great catch. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/backlog Issue is approved and in the backlog
Projects
None yet
Development

No branches or pull requests

3 participants