Skip to content

telemetry float32 #6048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kfox1111 opened this issue May 6, 2025 · 4 comments
Open

telemetry float32 #6048

kfox1111 opened this issue May 6, 2025 · 4 comments
Labels
help wanted Issues with this label are ready to start work but are in need of someone to do it priority/backlog Issue is approved and in the backlog

Comments

@kfox1111
Copy link
Contributor

kfox1111 commented May 6, 2025

Is it an issue things are putting times into float32's in telemetry?

https://github.com/spiffe/spire/blob/main/pkg/common/telemetry/uptime.go#L4

Seems like it might cause 2038 issues or similar. Should we just convert it all to float64?
@sorindumitru sorindumitru added the triage/in-progress Issue triage is in progress label May 6, 2025
@MarcosDY
Copy link
Collaborator

MarcosDY commented May 6, 2025

there a SetPrecisionGaugeWithLabels that we can use that has float64.

@MarcosDY
Copy link
Collaborator

MarcosDY commented May 8, 2025

What metrics needs to use this new Gauge?
I think our only issue is that it may cause compatibility issues with dashboards using float32 version

@kfox1111
Copy link
Contributor Author

kfox1111 commented May 8, 2025 •
edited
Loading

Anything with a time I think. I don't have an inventory of those. I found the one case. not sure if there are others or not.

@sorindumitru sorindumitru added help wanted Issues with this label are ready to start work but are in need of someone to do it priority/backlog Issue is approved and in the backlog and removed triage/in-progress Issue triage is in progress labels May 13, 2025
@sorindumitru
Copy link
Collaborator

Moving to backlog for changing the time metrics to precision gauge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Issues with this label are ready to start work but are in need of someone to do it priority/backlog Issue is approved and in the backlog
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sorindumitru @kfox1111 @MarcosDY