Fix: Disappearing starship prompt when reloading ~/.bashrc with both/either ble.sh and/or bash-preexec.sh
#6723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…either ble.sh and/or bash-preexec.sh are loaded There was a huge unnecessary `if/else` that only allowed: 1) To have preexec/precmd functions to be hooked into ble.sh 2) To have preexec/precmd functions to be hooked into bash-preexec.sh 3) To properly reset the prompt upon reloading This also fixes a bug where it checks whether starship preexec and precmd functions aren't already part of the bash-preexec functions in favour of constantly re-adding them after every reload
5 tasks
|
Don't know what to do to have this patch merged? Is the config schema not being up-to-date that downright unacceptable? I don't even understand what that means / why it's of this much relevance... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a huge unnecessary
if/elseinstarship.bashthat only allowed one of either:This also fixes a bug where it checks whether starship preexec and precmd functions aren't already part of the bash-preexec functions in favour of constantly re-adding them after every reload
Motivation and Context
Closes #6702
How Has This Been Tested?
I made a file with the contents of
starship.bashwhich I tested on default manjaro ~/.bashrc config.I tested:
bash-preexec.sh (latest version) - with first sourcing bash-preexec.sh and then sourcing starship.bash in ~/.bashrc
ble.sh (git version from AUR - latest version) - no change to config, ble.sh related lines at top and bottom of ~/.bashrc
both bash-preexec.sh and ble.sh
I have tested using MacOS
I have tested using Linux
I have tested using Windows
Checklist: